feat(pretty-format)!: remove ConvertAnsi plugin in favour of jest-serializer-ansi-escapes#13040
Merged
Conversation
sounisi5011
added a commit
to sounisi5011/npm-packages
that referenced
this pull request
Jul 22, 2022
…rmat` to `jest-serializer-ansi-escapes` The `ConvertAnsi` plugin has been removed from `pretty-format` by [#13040]. The replacement is [`jest-serializer-ansi-escapes`]. [#13040]: jestjs/jest#13040 [`jest-serializer-ansi-escapes`]: https://github.com/mrazauskas/jest-serializer-ansi-escapes
sounisi5011
added a commit
to sounisi5011/npm-packages
that referenced
this pull request
Jul 22, 2022
…rmat` to `jest-serializer-ansi-escapes` (#573) * test(@sounisi5011/jest-binary-data-matchers): migrate from `pretty-format` to `jest-serializer-ansi-escapes` The `ConvertAnsi` plugin has been removed from `pretty-format` by [#13040]. The replacement is [`jest-serializer-ansi-escapes`]. [#13040]: jestjs/jest#13040 [`jest-serializer-ansi-escapes`]: https://github.com/mrazauskas/jest-serializer-ansi-escapes * test(@sounisi5011/jest-binary-data-matchers): update snapshots
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #12881
Summary
Perhaps it makes sense to remove
ConvertAnsiplugin frompretty-formatpackage in favour ofjest-serializer-ansi-escapes?Gains are tiny: less code shipped, no need for extra export.
Also the export was missing type declaration (see #12881). Plugin as a separate package resolves this issue.
Test plan
Green CI.