address violations of warning unreachable-code-return

Summary: TSIA.

Reviewed By: iahs

Differential Revision: D95684728

fbshipit-source-id: 3d5976286fb101bfb819e2d89c87c35dea2633e8

Author: yfeldblum

thrift/lib/cpp/test/loadgen/GaussianMixtureModel.cpp

@@ -74,7 +74,6 @@ double GaussianMixtureModel::getSample() {
   }
   LOG(FATAL)
       << "The weights vector or the uniform random real are probably wrong.";
-  return 0;
 }
 
 } // namespace apache::thrift::loadgen

thrift/lib/cpp2/server/CPUConcurrencyController.cpp

@@ -355,7 +355,7 @@ uint32_t CPUConcurrencyController::getLimitUsage(
       return totalRequestSince * 1000L / milliSince;
     }
     default:
-      DCHECK(false);
+      LOG(DFATAL) << "unexpected CPUConcurrencyController method";
       return 0;
   }
 }

thrift/lib/cpp2/test/InteractionTest.cpp

@@ -158,7 +158,6 @@ TEST(InteractionTest, PrioritizedInteractionRequest) {
     std::this_thread::sleep_for(std::chrono::milliseconds(10));
     if (std::chrono::steady_clock::now() - start > std::chrono::seconds(5)) {
       FAIL() << "Timed out waiting for requests to be queued";
-      return;
     }
   }
 

thrift/lib/cpp2/transport/rocket/server/ThriftRocketServerHandler.cpp

@@ -1077,7 +1077,7 @@ void ThriftRocketServerHandler::handleInjectedFault(
               << connContext_.getPeerAddress()->getAddressStr();
       return;
     case InjectedFault::DISCONNECT:
-      return request->closeConnection(
+      request->closeConnection(
           folly::make_exception_wrapper<TApplicationException>(
               TApplicationException::INJECTED_FAILURE, "injected failure"));
       return;