This repository was archived by the owner on Feb 6, 2023. It is now read-only.
Upgrades ESLint and related plugins/configs. #2231
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes some security issues reported by github too.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mrkev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
mmissey
pushed a commit
to mmissey/draft-js
that referenced
this pull request
Mar 24, 2020
Summary: This fixes some security issues reported by GitHub. There are still warnings on the lint, but no errors. I had to make some changes. Most notably: ## `.eslintrc.js` Changed the value of `rules` because it was required by the new `eslint-plugin-prettier`. See prettier/eslint-plugin-prettier@478c7e5 ## `/src` Changed some lints referencing `fb-www/`. ESLint 6 reports errors on rules that aren't found (see: eslint/eslint@2d32a9e). For some reason `fb-www` rules are not found. Changing the disables to be `/* eslint-disable-next-line */` makes them valid both the open source config and Facebook's internal config. Pull Request resolved: facebookarchive#2231 Reviewed By: claudiopro Differential Revision: D18206971 Pulled By: mrkev fbshipit-source-id: 55ca3e8a24c61250dd7cd01220ed55c73a140b9d
vilemj-Viclick
pushed a commit
to kontent-ai/draft-js
that referenced
this pull request
Jul 16, 2020
Summary: This fixes some security issues reported by GitHub. There are still warnings on the lint, but no errors. I had to make some changes. Most notably: ## `.eslintrc.js` Changed the value of `rules` because it was required by the new `eslint-plugin-prettier`. See prettier/eslint-plugin-prettier@478c7e5 ## `/src` Changed some lints referencing `fb-www/`. ESLint 6 reports errors on rules that aren't found (see: eslint/eslint@2d32a9e). For some reason `fb-www` rules are not found. Changing the disables to be `/* eslint-disable-next-line */` makes them valid both the open source config and Facebook's internal config. Pull Request resolved: facebookarchive#2231 Reviewed By: claudiopro Differential Revision: D18206971 Pulled By: mrkev fbshipit-source-id: 55ca3e8a24c61250dd7cd01220ed55c73a140b9d
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: This fixes some security issues reported by GitHub. There are still warnings on the lint, but no errors. I had to make some changes. Most notably: ## `.eslintrc.js` Changed the value of `rules` because it was required by the new `eslint-plugin-prettier`. See prettier/eslint-plugin-prettier@478c7e5 ## `/src` Changed some lints referencing `fb-www/`. ESLint 6 reports errors on rules that aren't found (see: eslint/eslint@2d32a9e). For some reason `fb-www` rules are not found. Changing the disables to be `/* eslint-disable-next-line */` makes them valid both the open source config and Facebook's internal config. Pull Request resolved: facebookarchive/draft-js#2231 Reviewed By: claudiopro Differential Revision: D18206971 Pulled By: mrkev fbshipit-source-id: 55ca3e8a24c61250dd7cd01220ed55c73a140b9d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes some security issues reported by GitHub:
.eslintrc.jsChanged the value of
rulesbecause it was required by the neweslint-plugin-prettier. See prettier/eslint-plugin-prettier@478c7e5/srcChanged some lints referencing
fb-www/. ESLint 6 reports errors on rules that aren't found (see: eslint/eslint@2d32a9e). For some reasonfb-wwwrules are not found. Changing the disables to be/* eslint-disable-next-line */makes them valid both the open source config and Facebook's internal config.Etc
Ran tests and ran lint.