Fix npm run dev #2030
Fix npm run dev #2030
Conversation
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email [email protected] with your details so we can update your status. |
|
I sent an email based on the feedback from the cla-bot, waiting. |
There was a problem hiding this comment.
Thanks for contributing this fix @fabiomcosta! This breakage went under the radar during the upgrade to Gulp 4.
Please look into my comment inline below, it's otherwise good.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@claudiopro is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: **Summary** Fixes the `npm run dev` command, which currently fails when run. **Test Plan** `npm run dev` `yarn run dev` Pull Request resolved: facebookarchive#2030 Differential Revision: D14406346 fbshipit-source-id: 9a689d4ef3097a2728f5603d20097b98b6c3a8df
Summary: **Summary** Fixes the `npm run dev` command, which currently fails when run. **Test Plan** `npm run dev` `yarn run dev` Pull Request resolved: facebookarchive#2030 Differential Revision: D14406346 fbshipit-source-id: 9a689d4ef3097a2728f5603d20097b98b6c3a8df
Summary: **Summary** Fixes the `npm run dev` command, which currently fails when run. **Test Plan** `npm run dev` `yarn run dev` Pull Request resolved: facebookarchive/draft-js#2030 Differential Revision: D14406346 fbshipit-source-id: 9a689d4ef3097a2728f5603d20097b98b6c3a8df
3 participants
Summary
Fixes the
npm run devcommand, which currently fails when run.Test Plan
npm run devyarn run dev