This repository was archived by the owner on Feb 6, 2023. It is now read-only.
Normalize copyright headers to BSD + patents grant and drop the year #1964
+840
−849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niveditc
approved these changes
Dec 30, 2018
Contributor
niveditc
left a comment
niveditc
left a comment
There was a problem hiding this comment.
Looks good! Thanks for taking a stab at this again 👍
The issue last time was with out internal linter not recognizing copyright headers without year (see D9754843) - not sure if that got fixed, let's check it out on import :)
claudiopro
force-pushed
the
fix-copyright-headers
branch
from
06380f4 to
48f2457
Compare
Contributor
Author
|
Sounds good, thanks @niveditc ! 😄 |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Closed
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
…acebookarchive#1964) Summary: **Summary** This PR follows up work started by niveditc on facebookarchive#1860 and suspended because of limitations with tooling. Let's give it another try. - Remove all copyright years - Correct copyright headers under `website/` referencing the MIT license - Inline `All rights reserved.` on the same line of the copyright - Fixes copyright headers of examples incorrectly using headers for source files The PR also normalizes copyright headers to BSD with patents grant, as some files were later added with the newest MIT license applied to React and other OSS projects. We should discuss the switch to MIT for Draft.js as well. **Test Plan** Manual inspection of files + `yarn lint` Pull Request resolved: facebookarchive#1964 Differential Revision: D13562427 fbshipit-source-id: 6a15d29ff56a6340ee2a0f13f278b207f1761d28
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
…(#1964) Summary: **Summary** This PR follows up work started by niveditc on #1860 and suspended because of limitations with tooling. Let's give it another try. - Remove all copyright years - Correct copyright headers under `website/` referencing the MIT license - Inline `All rights reserved.` on the same line of the copyright - Fixes copyright headers of examples incorrectly using headers for source files The PR also normalizes copyright headers to BSD with patents grant, as some files were later added with the newest MIT license applied to React and other OSS projects. We should discuss the switch to MIT for Draft.js as well. **Test Plan** Manual inspection of files + `yarn lint` Pull Request resolved: facebookarchive/draft-js#1964 Differential Revision: D13562427 fbshipit-source-id: 6a15d29ff56a6340ee2a0f13f278b207f1761d28
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
…(#1964) Summary: **Summary** This PR follows up work started by niveditc on #1860 and suspended because of limitations with tooling. Let's give it another try. - Remove all copyright years - Correct copyright headers under `website/` referencing the MIT license - Inline `All rights reserved.` on the same line of the copyright - Fixes copyright headers of examples incorrectly using headers for source files The PR also normalizes copyright headers to BSD with patents grant, as some files were later added with the newest MIT license applied to React and other OSS projects. We should discuss the switch to MIT for Draft.js as well. **Test Plan** Manual inspection of files + `yarn lint` Pull Request resolved: facebookarchive/draft-js#1964 Differential Revision: D13562427 fbshipit-source-id: 6a15d29ff56a6340ee2a0f13f278b207f1761d28
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR follows up work started by @niveditc on #1860 and suspended because of limitations with tooling. Let's give it another try.
website/referencing the MIT licenseAll rights reserved.on the same line of the copyrightThe PR also normalizes copyright headers to BSD with patents grant, as some files were later added with the newest MIT license applied to React and other OSS projects. We should discuss the switch to MIT for Draft.js as well.
Test Plan
Manual inspection of files +
yarn lint