This repository was archived by the owner on Feb 6, 2023. It is now read-only.
Add issue triage guidelines to CONTRIBUTING.md #1896
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niveditc
requested review from
claudiopro,
elboman,
flarnie,
juliankrispel and
mrkev
Contributor
|
That’s awesome!
It’d be great imo to clarify what kind of prs will be accepted. So the
community knows before they open one. Wdyt?
…On Sun, Oct 14, 2018 at 8:54 PM Nivedita Chopra ***@***.***> wrote:
@niveditc <https://github.com/niveditc> requested your review on: #1896
<#1896> Add issue triage
guidelines to CONTRIBUTING.md.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1896 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABIhWvbYJQP0XiPwk0jMF1wdSnDFlekzks5uk5aMgaJpZM4XbTNs>
.
|
Contributor
|
Though that is a different issue altogether 😅
On Sun, Oct 14, 2018 at 9:04 PM Julian Krispel-Samsel <
[email protected]> wrote:
… That’s awesome!
It’d be great imo to clarify what kind of prs will be accepted. So the
community knows before they open one. Wdyt?
On Sun, Oct 14, 2018 at 8:54 PM Nivedita Chopra ***@***.***>
wrote:
> @niveditc <https://github.com/niveditc> requested your review on: #1896
> <#1896> Add issue triage
> guidelines to CONTRIBUTING.md.
>
> —
> You are receiving this because your review was requested.
> Reply to this email directly, view it on GitHub
> <#1896 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ABIhWvbYJQP0XiPwk0jMF1wdSnDFlekzks5uk5aMgaJpZM4XbTNs>
> .
>
|
Contributor
Author
|
@juliankrispel - totally agreed! I just opened the following issues:
|
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
niveditc has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
This is great for new contributors! Thanks for writing this up @niveditc. I'd make an example for the last bullet point, e.g. chrome, firefox, macos, android and so forth. Note that osx should be renamed to macos to match the current name of the OS (I just renamed it). |
Contributor
Author
|
@claudiopro - thanks for the suggestion! I added in the examples :) |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
niveditc has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
Summary: **Summary** We've been loosely following these guidelines for the past month & they seem to be working well. Adding to `CONTRIBUTING.md` to make it more visible. **Test Plan** <img width="793" alt="screenshot 2018-10-14 12 54 05" src="https://user-images.githubusercontent.com/2357761/46921447-40040880-cfb0-11e8-8e74-386c17a4778e.png"> Pull Request resolved: facebookarchive#1896 Differential Revision: D10382836 fbshipit-source-id: e96336a96f27681b59510fcd15baa30e146ed631
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** We've been loosely following these guidelines for the past month & they seem to be working well. Adding to `CONTRIBUTING.md` to make it more visible. **Test Plan** <img width="793" alt="screenshot 2018-10-14 12 54 05" src="https://user-images.githubusercontent.com/2357761/46921447-40040880-cfb0-11e8-8e74-386c17a4778e.png"> Pull Request resolved: facebookarchive/draft-js#1896 Differential Revision: D10382836 fbshipit-source-id: e96336a96f27681b59510fcd15baa30e146ed631
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: **Summary** We've been loosely following these guidelines for the past month & they seem to be working well. Adding to `CONTRIBUTING.md` to make it more visible. **Test Plan** <img width="793" alt="screenshot 2018-10-14 12 54 05" src="https://user-images.githubusercontent.com/2357761/46921447-40040880-cfb0-11e8-8e74-386c17a4778e.png"> Pull Request resolved: facebookarchive/draft-js#1896 Differential Revision: D10382836 fbshipit-source-id: e96336a96f27681b59510fcd15baa30e146ed631
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've been loosely following these guidelines for the past month & they seem to be working well. Adding to
CONTRIBUTING.mdto make it more visible.Test Plan
