This repository was archived by the owner on Feb 6, 2023. It is now read-only.
Fixes some drag-n-drop problems #1599
Closed
+27
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This bug is present on Chrome on Linux, bit not on Windows |
niveditc
suggested changes
Oct 7, 2018
Contributor
niveditc
left a comment
niveditc
left a comment
There was a problem hiding this comment.
Hey @ukrbublik - thank you for submitting this PR.
A few action items:
- This change seems risky without a test plan. Can you either add tests for this code, or add a video to the test plan of the bug & fix?
- Please rebase to master & remove the merge commit + eslint fix from this PR.
- Please remove the commented out code in the commit (
//editor._internalDrag = false;).
ukrbublik
force-pushed
the
bugfix-drag-n-drop
branch
3 times, most recently
from
94bb7a4 to
57c05cd
Compare
Fixed issue facebookarchive#1454 (partial) Fixed issue facebookarchive#1383
ukrbublik
force-pushed
the
bugfix-drag-n-drop
branch
from
57c05cd to
fd8ca01
Compare
Contributor
Author
|
Hi @niveditc |
niveditc
approved these changes
Oct 8, 2018
Contributor
niveditc
left a comment
niveditc
left a comment
There was a problem hiding this comment.
This looks good - thanks for fixing the nits & adding a thorough test plan.
Contributor
|
@ukrbublik, next steps are that:
|
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
niveditc has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
Summary: **Summary** Fixes issue facebookarchive#1383. Fixes problem which is: onDrop breaks onSelect/onChange events. Fixes issue facebookarchive#1454 (partial). Fixes problem which is: after first internal drop dragged text will not be moved to target position, but copied. The solution is to set `editor._internalDrag` to false not during onDragOver events, but after end of drag-n-drop. **Test Plan** Attached reproducable videos (on Chrome for Linux) Issue facebookarchive#1383 before and after:   Issue facebookarchive#1454 before and after:   Pull Request resolved: facebookarchive#1599 Differential Revision: D10236073 fbshipit-source-id: 3b7b816630f3b5b15931cb53782a1d5b9e9d5121
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
Summary: **Summary** Fixes issue facebookarchive#1383. Fixes problem which is: onDrop breaks onSelect/onChange events. Fixes issue facebookarchive#1454 (partial). Fixes problem which is: after first internal drop dragged text will not be moved to target position, but copied. The solution is to set `editor._internalDrag` to false not during onDragOver events, but after end of drag-n-drop. **Test Plan** Attached reproducable videos (on Chrome for Linux) Issue facebookarchive#1383 before and after:   Issue facebookarchive#1454 before and after:   Pull Request resolved: facebookarchive#1599 Differential Revision: D10236073 fbshipit-source-id: 3b7b816630f3b5b15931cb53782a1d5b9e9d5121
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** Fixes issue #1383. Fixes problem which is: onDrop breaks onSelect/onChange events. Fixes issue #1454 (partial). Fixes problem which is: after first internal drop dragged text will not be moved to target position, but copied. The solution is to set `editor._internalDrag` to false not during onDragOver events, but after end of drag-n-drop. **Test Plan** Attached reproducable videos (on Chrome for Linux) Issue #1383 before and after:   Issue #1454 before and after:   Pull Request resolved: facebookarchive/draft-js#1599 Differential Revision: D10236073 fbshipit-source-id: 3b7b816630f3b5b15931cb53782a1d5b9e9d5121
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: **Summary** Fixes issue #1383. Fixes problem which is: onDrop breaks onSelect/onChange events. Fixes issue #1454 (partial). Fixes problem which is: after first internal drop dragged text will not be moved to target position, but copied. The solution is to set `editor._internalDrag` to false not during onDragOver events, but after end of drag-n-drop. **Test Plan** Attached reproducable videos (on Chrome for Linux) Issue #1383 before and after:   Issue #1454 before and after:   Pull Request resolved: facebookarchive/draft-js#1599 Differential Revision: D10236073 fbshipit-source-id: 3b7b816630f3b5b15931cb53782a1d5b9e9d5121
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #1383. Fixes problem which is: onDrop breaks onSelect/onChange events.
Fixes issue #1454 (partial). Fixes problem which is: after first internal drop dragged text will not be moved to target position, but copied.
The solution is to set
editor._internalDragto false not during onDragOver events, but after end of drag-n-drop.Test Plan
Attached reproducable videos (on Chrome for Linux)
Issue #1383 before and after:
Issue #1454 before and after: