Handle ReactDOM type errors

Summary:
When re-enabling ReactDOM Flow typing, we discovered Flow errors.

This commit suppresses the errors.

The controller you requested could not be found.
The controller you requested could not be found.

Reviewed By: flarnie

Differential Revision: D9224137

fbshipit-source-id: e5cbc4887d3296ae9a71523da3bb37de5f16ac4d

Author: catchingash

src/component/base/DraftEditor.react.js

@@ -260,7 +260,9 @@ class DraftEditor extends React.Component<DraftEditorProps, State> {
    * editor mode, if any has been specified.
    */
   _buildHandler(eventName: string): Function {
-    const flushControlled = ReactDOM.unstable_flushControlled;
+    const flushControlled: (fn: Function) => void =
+      // $FlowFixMe flushControlled is an unstable feature, so not Flow typed
+      ReactDOM.unstable_flushControlled;
     // Wrap event handlers in `flushControlled`. In sync mode, this is
     // effetively a no-op. In async mode, this ensures all updates scheduled
     // inside the handler are flushed before React yields to the browser.

src/component/contents/DraftEditorLeaf.react.js

@@ -103,6 +103,7 @@ class DraftEditorLeaf extends React.Component<Props> {
 
     if (child.nodeType === Node.TEXT_NODE) {
       targetNode = child;
+      // $FlowFixMe child may also be an Element, not just Node
     } else if (child.tagName === 'BR') {
       targetNode = node;
     } else {

src/component/contents/__tests__/DraftEditorTextNode-test.js

@@ -44,17 +44,19 @@ const initializeAsNonIE = () => {
 };
 
 const expectPopulatedSpan = (stub, testString) => {
-  const node = ReactDOM.findDOMNode(stub);
+  // $FlowExpectedError node could be null
+  const node: Element = ReactDOM.findDOMNode(stub);
   expect(node.tagName).toBe('SPAN');
   expect(node.childNodes.length).toBe(1);
-  expect(node.firstChild.textContent).toBe(testString);
+  expect(node.firstChild && node.firstChild.textContent).toBe(testString);
 };
 
 test('must initialize correctly with an empty string, non-IE', function() {
   initializeAsNonIE();
   const stub = renderIntoContainer(
     <DraftEditorTextNode>{''}</DraftEditorTextNode>,
   );
+  // $FlowExpectedError we know node is an Element
   expect(ReactDOM.findDOMNode(stub).tagName).toBe('BR');
 });
 
@@ -143,11 +145,13 @@ test('must skip updates if text already matches DOM, non-IE', function() {
 
   renderIntoContainer(<DraftEditorTextNode>{TEST_A}</DraftEditorTextNode>);
 
+  // $FlowExpectedError property render is missing in HTMLDivElement
   expect(stub.render.mock.calls.length).toBe(0);
 
   // Sanity check that updating is performed when appropriate.
   renderIntoContainer(<DraftEditorTextNode>{TEST_B}</DraftEditorTextNode>);
 
+  // $FlowExpectedError property render is missing in HTMLDivElement
   expect(stub.render.mock.calls.length).toBe(1);
 });
 
@@ -161,11 +165,13 @@ test('must skip updates if text already matches DOM, IE', function() {
 
   renderIntoContainer(<DraftEditorTextNode>{TEST_A}</DraftEditorTextNode>);
 
+  // $FlowExpectedError property render is missing in HTMLDivElement
   expect(stub.render.mock.calls.length).toBe(0);
 
   // Sanity check that updating is performed when appropriate.
   renderIntoContainer(<DraftEditorTextNode>{TEST_B}</DraftEditorTextNode>);
 
+  // $FlowExpectedError property render is missing in HTMLDivElement
   expect(stub.render.mock.calls.length).toBe(1);
 });
 
@@ -177,6 +183,7 @@ test('must update from non-empty to empty, non-IE', function() {
 
   renderIntoContainer(<DraftEditorTextNode>{''}</DraftEditorTextNode>);
 
+  // $FlowExpectedError we know node is an Element
   expect(ReactDOM.findDOMNode(stub).tagName).toBe('BR');
 });
 
@@ -206,9 +213,11 @@ test('must force unchanged text back into the DOM', function() {
     <DraftEditorTextNode>{TEST_A}</DraftEditorTextNode>,
   );
 
+  // $FlowExpectedError we know node is not null
   ReactDOM.findDOMNode(stub).textContent = TEST_B;
 
   renderIntoContainer(<DraftEditorTextNode>{TEST_A}</DraftEditorTextNode>);
 
+  // $FlowExpectedError we know node is not null
   expect(ReactDOM.findDOMNode(stub).textContent).toBe(TEST_A);
 });