This repository was archived by the owner on Feb 6, 2023. It is now read-only.
Commit 4de1345
Move uglifyjs-webpack-plugin to devDependencies
Summary:
**Summary**
This dependency got introduced in a separate commit (f8ca29d) from the others in #1644. I imagine this is a mistake since it only provides dev-time tooling.
**Test Plan**
For development, we can try a fresh install of the project:
1. `rm -rf node_modules`
2. `yarn install`. This runs `npm run build` via the `prepublish` script, so if it works it's good to go.
I don't think dependencies and devDependencies are processed any differently in a development environment, so not sure this check is even necessary.
For the published package:
1. `mkdir test`
2. `npm init -y`
3. `npm install git+https://github.com/thibaudcolas/draft-js.git#patch-2`
4. `npm ls --depth=1`
The `npm ls` result should be:
```
├─┬ [email protected] (git+https://github.com/thibaudcolas/draft-js.git#cb06920d0f3dea77692680dddba6ec475663c7b2)
│ ├── [email protected]
│ ├── [email protected]
│ └── [email protected]
├── UNMET PEER DEPENDENCY react@^0.14.0 || ^15.0.0-rc || ^16.0.0-rc || ^16.0.0
└── UNMET PEER DEPENDENCY react-dom@^0.14.0 || ^15.0.0-rc || ^16.0.0-rc || ^16.0.0
```
Note `uglifyjs-webpack-plugin` is absent, whereas it would have been there with `npm install git+https://github.com/thibaudcolas/draft-js.git#master`.
Closes #1653
Differential Revision: D7073476
fbshipit-source-id: f69e31c2ca252062d2d66080055fd08b88c5a2751 parent f4bc3a7 commit 4de1345
1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
39 | | - | |
| 38 | + | |
40 | 39 | | |
41 | 40 | | |
42 | 41 | | |
| |||
81 | 80 | | |
82 | 81 | | |
83 | 82 | | |
| 83 | + | |
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
| |||
0 commit comments