Replace direct stack trace output with managed error handling

Author: Marukome0743

src/main/java/io/fabric8/maven/docker/assembly/DockerAssemblyManager.java

@@ -429,7 +429,6 @@ private File createChangedFilesTarBall(File archive, File archiveDir) throws Moj
         } catch (IOException e) {
             throw new MojoExecutionException("Cannot create archive " + archive, e);
         } catch (RuntimeException e) {
-            e.printStackTrace();
             throw e;
         }
     }

src/main/java/io/fabric8/maven/docker/util/AnsiLogger.java

@@ -84,7 +84,7 @@ public AnsiLogger(Log log, boolean useColor, String verbose, boolean batchMode,
         try {
             initializePrintWriter();
         } catch (FileNotFoundException e) {
-            e.printStackTrace();
+            log.error(prefix + "Cannot write log output to " + outputFile, e);
         }
     }
 

src/test/java/io/fabric8/maven/docker/assembly/DockerAssemblyManagerTest.java

@@ -243,6 +243,25 @@ void testArchiveCreationDockerfileNoAssembly() throws MojoExecutionException, No
         verifyArchiveManager();
     }
 
+    @Test
+    void archiveCreationPropagatesRuntimeException() throws IOException, NoSuchArchiverException {
+        MojoParameters mojoParams = mockMojoParams(mockMavenProject());
+        BuildImageConfiguration buildImageConfiguration = new BuildImageConfiguration.Builder()
+            .dockerFile(DockerAssemblyManagerTest.class.getResource("/docker/Dockerfile.test").getPath())
+            .build();
+        buildImageConfiguration.initAndValidate(logger);
+        RuntimeException failure = new IllegalStateException("Archive creation failed");
+
+        Mockito.doReturn(tarArchiver).when(archiverManager).getArchiver("tar");
+        Mockito.doThrow(failure).when(tarArchiver).createArchive();
+
+        RuntimeException thrown = Assertions.assertThrows(RuntimeException.class,
+            () -> assemblyManager.createDockerTarArchive(
+                "test_image", mojoParams, buildImageConfiguration, logger, null));
+
+        Assertions.assertSame(failure, thrown);
+    }
+
     private void verifyArchiveManager() {
         List<FileSet> fileSets = getFileSetsToVerify(2);
         Assertions.assertEquals("build", fileSets.get(0).getDirectory().getName());

src/test/java/io/fabric8/maven/docker/util/AnsiLoggerTest.java

@@ -23,13 +23,27 @@
 import org.fusesource.jansi.Ansi;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
+
+import java.io.FileNotFoundException;
+import java.nio.file.Path;
 
 /**
  * @author roland
  * @since 07/10/16
  */
 class AnsiLoggerTest {
 
+    @Test
+    void logOutputInitializationFailureUsesMavenLogger(@TempDir Path temporaryDirectory) {
+        TestLog testLog = new TestLog();
+
+        new AnsiLogger(testLog, false, null, false, "T>", temporaryDirectory.toFile());
+
+        Assertions.assertEquals("T>Cannot write log output to " + temporaryDirectory, testLog.getMessage());
+        Assertions.assertInstanceOf(FileNotFoundException.class, testLog.getThrowable());
+    }
+
     @Test
     void emphasizeDebug() {
         TestLog testLog = new TestLog() {
@@ -198,6 +212,7 @@ void emphasizeError() {
 
     private class TestLog extends DefaultLog {
         private String message;
+        private Throwable throwable;
 
         public TestLog() {
             super(new ConsoleLogger());
@@ -227,13 +242,25 @@ public void error(CharSequence content) {
             super.error(content);
         }
 
+        @Override
+        public void error(CharSequence content, Throwable error) {
+            this.message = content.toString();
+            this.throwable = error;
+            super.error(content, error);
+        }
+
         void reset() {
             message = null;
+            throwable = null;
         }
 
         public String getMessage() {
             return message;
         }
+
+        public Throwable getThrowable() {
+            return throwable;
+        }
     }
 
 }