Skip to content

Commit 5e16f40

Browse files
hiowenlukedougwilson
authored andcommitted
examples: use 1-based visitor count in cookie-sessions
closes #3312
1 parent 43dff4c commit 5e16f40

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

examples/cookie-sessions/index.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,8 @@ app.use(count);
1515

1616
// custom middleware
1717
function count(req, res) {
18-
req.session.count = req.session.count || 0;
19-
var n = req.session.count++;
20-
res.send('viewed ' + n + ' times\n');
18+
req.session.count = (req.session.count || 0) + 1
19+
res.send('viewed ' + req.session.count + ' times\n')
2120
}
2221

2322
/* istanbul ignore next */

test/acceptance/cookie-sessions.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ describe('cookie-sessions', function () {
77
it('should display no views', function (done) {
88
request(app)
99
.get('/')
10-
.expect(200, 'viewed 0 times\n', done)
10+
.expect(200, 'viewed 1 times\n', done)
1111
})
1212

1313
it('should set a session cookie', function (done) {
@@ -20,12 +20,12 @@ describe('cookie-sessions', function () {
2020
it('should display 1 view on revisit', function (done) {
2121
request(app)
2222
.get('/')
23-
.expect(200, 'viewed 0 times\n', function (err, res) {
23+
.expect(200, 'viewed 1 times\n', function (err, res) {
2424
if (err) return done(err)
2525
request(app)
2626
.get('/')
2727
.set('Cookie', getCookies(res))
28-
.expect(200, 'viewed 1 times\n', done)
28+
.expect(200, 'viewed 2 times\n', done)
2929
})
3030
})
3131
})

0 commit comments

Comments
 (0)