Allow multiple destructive indices #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evrimfeyyaz
changed the title
bradbyte
approved these changes
Jun 21, 2021
|
Is there a plan for when this is going to be released? |
Contributor
|
@JakeSidSmith I'm sorry, I need to run the deploy script. |
bradbyte
pushed a commit
that referenced
this pull request
Aug 9, 2021
# [3.9.0](v3.8.0...v3.9.0) (2021-08-09) ### Bug Fixes * allow callback to be async ([#183](#183)) ([d0d5182](d0d5182)) * center icons with titles ([#188](#188)) ([d48c323](d48c323)) ### Features * add `userInterfaceStyle` option for iOS ([#206](#206)) ([735cfa5](735cfa5)) * Allow multiple destructive indices ([#210](#210)) ([81112b9](81112b9))
bradbyte
pushed a commit
that referenced
this pull request
Aug 9, 2021
# [3.9.0](v3.8.0...v3.9.0) (2021-08-09) ### Bug Fixes * allow callback to be async ([#183](#183)) ([d0d5182](d0d5182)) * center icons with titles ([#188](#188)) ([d48c323](d48c323)) ### Features * add `userInterfaceStyle` option for iOS ([#206](#206)) ([735cfa5](735cfa5)) * Allow multiple destructive indices ([#210](#210)) ([81112b9](81112b9))
Contributor
|
@JakeSidSmith I'm sorry for the delay 🤦🏻♂️ . This is now released in |
robertomartinez09515
added a commit
to robertomartinez09515/action-sheet-react-best-proj
that referenced
this pull request
Jul 25, 2022
# [3.9.0](expo/react-native-action-sheet@v3.8.0...v3.9.0) (2021-08-09) ### Bug Fixes * allow callback to be async ([#183](expo/react-native-action-sheet#183)) ([d0d5182](expo/react-native-action-sheet@d0d5182)) * center icons with titles ([#188](expo/react-native-action-sheet#188)) ([d48c323](expo/react-native-action-sheet@d48c323)) ### Features * add `userInterfaceStyle` option for iOS ([#206](expo/react-native-action-sheet#206)) ([735cfa5](expo/react-native-action-sheet@735cfa5)) * Allow multiple destructive indices ([#210](expo/react-native-action-sheet#210)) ([81112b9](expo/react-native-action-sheet@81112b9))
robertomartinez09515
added a commit
to robertomartinez09515/action-sheet-react-best-proj
that referenced
this pull request
Jul 25, 2022
# [3.9.0](expo/react-native-action-sheet@v3.8.0...v3.9.0) (2021-08-09) ### Bug Fixes * allow callback to be async ([#183](expo/react-native-action-sheet#183)) ([d0d5182](expo/react-native-action-sheet@d0d5182)) * center icons with titles ([#188](expo/react-native-action-sheet#188)) ([d48c323](expo/react-native-action-sheet@d48c323)) ### Features * add `userInterfaceStyle` option for iOS ([#206](expo/react-native-action-sheet#206)) ([735cfa5](expo/react-native-action-sheet@735cfa5)) * Allow multiple destructive indices ([#210](expo/react-native-action-sheet#210)) ([81112b9](expo/react-native-action-sheet@81112b9))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for providing multiple indices to the
destructiveIndexoption.This is already supported in ActionSheetIOS. Please note that React Native's type definitions are not updated and it seems that
number[]is not a valid type fordestructiveIndex. You can easily test it and see that it actually works though.I have also added support for multiple destructive indices on Android.
Resolves #25.