ReLU kernel: never output -0.0

danieldk · danieldk · commit f5feb1caf98e · 2022-04-05T20:38:20.000+02:00
diff --git a/thinc/backends/cpu_kernels.hh b/thinc/backends/cpu_kernels.hh
@@ -271,7 +271,7 @@ void cpu_relu(A* X, L N)
     static_assert(std::is_integral<L>::value, "Array length should be integral");
 
     for (L i = 0; i < N; ++i) {
-        if (X[i] < 0) {
+        if (X[i] <= 0.0) {
             X[i] = 0.0;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -271,7 +271,7 @@ void cpu_relu(A* X, L N)`
`271`	`271`	`static_assert(std::is_integral<L>::value, "Array length should be integral");`
`272`	`272`
`273`	`273`	`for (L i = 0; i < N; ++i) {`
`274`		`- if (X[i] < 0) {`
	`274`	`+ if (X[i] <= 0.0) {`
`275`	`275`	`X[i] = 0.0;`
`276`	`276`	`}`
`277`	`277`	`}`