Skip to content

Commit 486e098

Browse files
committed
Revert use of noexcept on cblas functions
1 parent 1299847 commit 486e098

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

thinc/backends/cblas.pxd

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@ from libcpp.memory cimport shared_ptr
22

33
ctypedef void (*sgemm_ptr)(bint transA, bint transB, int M, int N, int K,
44
float alpha, const float* A, int lda, const float *B,
5-
int ldb, float beta, float* C, int ldc) nogil noexcept
5+
int ldb, float beta, float* C, int ldc) nogil
66

77

88
ctypedef void (*saxpy_ptr)(int N, float alpha, const float* X, int incX,
9-
float *Y, int incY) nogil noexcept
9+
float *Y, int incY) nogil
1010

1111

1212
ctypedef void (*daxpy_ptr)(int N, double alpha, const double* X, int incX,
13-
double *Y, int incY) nogil noexcept
13+
double *Y, int incY) nogil
1414

1515

1616
# Forward-declaration of the BlasFuncs struct. This struct must be opaque, so
@@ -29,9 +29,9 @@ cdef class CBlas:
2929
#
3030
# See https://github.com/explosion/thinc/pull/700 for more information.
3131

32-
cdef daxpy_ptr daxpy(CBlas cblas) nogil noexcept
33-
cdef saxpy_ptr saxpy(CBlas cblas) nogil noexcept
34-
cdef sgemm_ptr sgemm(CBlas cblas) nogil noexcept
35-
cdef void set_daxpy(CBlas cblas, daxpy_ptr daxpy) nogil noexcept
36-
cdef void set_saxpy(CBlas cblas, saxpy_ptr saxpy) nogil noexcept
37-
cdef void set_sgemm(CBlas cblas, sgemm_ptr sgemm) nogil noexcept
32+
cdef daxpy_ptr daxpy(CBlas cblas) nogil
33+
cdef saxpy_ptr saxpy(CBlas cblas) nogil
34+
cdef sgemm_ptr sgemm(CBlas cblas) nogil
35+
cdef void set_daxpy(CBlas cblas, daxpy_ptr daxpy) nogil
36+
cdef void set_saxpy(CBlas cblas, saxpy_ptr saxpy) nogil
37+
cdef void set_sgemm(CBlas cblas, sgemm_ptr sgemm) nogil

thinc/backends/cblas.pyx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,20 +22,20 @@ cdef class CBlas:
2222
funcs.sgemm = blis.cy.sgemm
2323
self.ptr = make_shared[BlasFuncs](funcs)
2424

25-
cdef daxpy_ptr daxpy(CBlas cblas) noexcept nogil:
25+
cdef daxpy_ptr daxpy(CBlas cblas) nogil:
2626
return deref(cblas.ptr).daxpy
2727

28-
cdef saxpy_ptr saxpy(CBlas cblas) noexcept nogil:
28+
cdef saxpy_ptr saxpy(CBlas cblas) nogil:
2929
return deref(cblas.ptr).saxpy
3030

31-
cdef sgemm_ptr sgemm(CBlas cblas) noexcept nogil:
31+
cdef sgemm_ptr sgemm(CBlas cblas) nogil:
3232
return deref(cblas.ptr).sgemm
3333

34-
cdef void set_daxpy(CBlas cblas, daxpy_ptr daxpy) noexcept nogil:
34+
cdef void set_daxpy(CBlas cblas, daxpy_ptr daxpy) nogil:
3535
deref(cblas.ptr).daxpy = daxpy
3636

37-
cdef void set_saxpy(CBlas cblas, saxpy_ptr saxpy) noexcept nogil:
37+
cdef void set_saxpy(CBlas cblas, saxpy_ptr saxpy) nogil:
3838
deref(cblas.ptr).saxpy = saxpy
3939

40-
cdef void set_sgemm(CBlas cblas, sgemm_ptr sgemm) noexcept nogil:
40+
cdef void set_sgemm(CBlas cblas, sgemm_ptr sgemm) nogil:
4141
deref(cblas.ptr).sgemm = sgemm

0 commit comments

Comments
 (0)