Merge pull request #1802 from exogee-technology/fix/sonarqube-fixes

thekevinbrown · web-flow · commit 3d9b5b947931 · 2025-06-04T16:53:15.000+10:00
Fix / SonarQube fixes
diff --git a/src/examples/auth-zero/src/admin-ui/custom-pages/welcome-page/component.tsx b/src/examples/auth-zero/src/admin-ui/custom-pages/welcome-page/component.tsx
@@ -59,9 +59,9 @@ export const WelcomePage = () => (
 				target="_blank"
 				rel="noopener noreferrer"
 			>
-				reach out to us on Slack
-			</a>
-			. We're here to help!
+				reach out to us on Slack.
+			</a>{' '}
+			We're here to help!
 		</p>
 		<Spacer height={30} />
 		<Button className={styles.button} href="/Album">
diff --git a/src/examples/aws-cognito/src/admin-ui/custom-pages/welcome-page/component.tsx b/src/examples/aws-cognito/src/admin-ui/custom-pages/welcome-page/component.tsx
@@ -26,9 +26,9 @@ export const WelcomePage = () => (
 				target="_blank"
 				rel="noopener noreferrer"
 			>
-				reach out to us on Slack
-			</a>
-			. We're here to help!
+				reach out to us on Slack.
+			</a>{' '}
+			We're here to help!
 		</p>
 		<Spacer height={30} />
 		<Button className={styles.button} href="/CognitoUser">
diff --git a/src/examples/databases/src/admin-ui/custom-pages/welcome-page/component.tsx b/src/examples/databases/src/admin-ui/custom-pages/welcome-page/component.tsx
@@ -58,9 +58,9 @@ export const WelcomePage = () => (
 				target="_blank"
 				rel="noopener noreferrer"
 			>
-				reach out to us on Slack
-			</a>
-			. We're here to help!
+				reach out to us on Slack.
+			</a>{' '}
+			We're here to help!
 		</p>
 		<Spacer height={30} />
 		<Button className={styles.button} href="/User">
diff --git a/src/examples/microsoft-entra/src/admin-ui/custom-pages/welcome-page/component.tsx b/src/examples/microsoft-entra/src/admin-ui/custom-pages/welcome-page/component.tsx
@@ -73,9 +73,9 @@ export const WelcomePage = () => (
 				target="_blank"
 				rel="noopener noreferrer"
 			>
-				reach out to us on Slack
-			</a>
-			. We're here to help!
+				reach out to us on Slack.
+			</a>{' '}
+			We're here to help!
 		</p>
 		<Spacer height={30} />
 		<Button className={styles.button} href="/Album">
diff --git a/src/examples/okta/src/admin-ui/custom-pages/welcome-page/component.tsx b/src/examples/okta/src/admin-ui/custom-pages/welcome-page/component.tsx
@@ -65,9 +65,9 @@ export const WelcomePage = () => (
 				target="_blank"
 				rel="noopener noreferrer"
 			>
-				reach out to us on Slack
-			</a>
-			. We're here to help!
+				reach out to us on Slack.
+			</a>{' '}
+			We're here to help!
 		</p>
 		<Spacer height={30} />
 		<Button className={styles.button} href="/Album">
diff --git a/src/examples/rest-with-auth/src/admin-ui/custom-pages/welcome-page/component.tsx b/src/examples/rest-with-auth/src/admin-ui/custom-pages/welcome-page/component.tsx
@@ -45,9 +45,9 @@ export const WelcomePage = () => {
 					target="_blank"
 					rel="noopener noreferrer"
 				>
-					reach out to us on Slack
-				</a>
-				. We're here to help!
+					reach out to us on Slack.
+				</a>{' '}
+				We're here to help!
 			</p>
 			<Spacer height={30} />
 			<Button className={styles.button} href="/User">
diff --git a/src/examples/s3-storage/src/admin-ui/custom-pages/welcome-page/component.tsx b/src/examples/s3-storage/src/admin-ui/custom-pages/welcome-page/component.tsx
@@ -92,9 +92,9 @@ export class Submission {
 				target="_blank"
 				rel="noopener noreferrer"
 			>
-				reach out to us on Slack
-			</a>
-			. We're here to help!
+				reach out to us on Slack.
+			</a>{' '}
+			We're here to help!
 		</p>
 		<Spacer height={30} />
 		<Button className={styles.button} href="/Submission">
diff --git a/src/examples/sqlite/src/admin-ui/custom-pages/welcome-page/component.tsx b/src/examples/sqlite/src/admin-ui/custom-pages/welcome-page/component.tsx
@@ -25,9 +25,9 @@ export const WelcomePage = () => (
 				target="_blank"
 				rel="noopener noreferrer"
 			>
-				reach out to us on Slack
-			</a>
-			. We're here to help!
+				reach out to us on Slack.
+			</a>{' '}
+			We're here to help!
 		</p>
 		<Spacer height={30} />
 		<Button className={styles.button} href="/Album">
diff --git a/src/examples/xero/src/admin-ui/custom-pages/welcome-page/component.tsx b/src/examples/xero/src/admin-ui/custom-pages/welcome-page/component.tsx
@@ -23,9 +23,9 @@ export const WelcomePage = () => (
 				target="_blank"
 				rel="noopener noreferrer"
 			>
-				reach out to us on Slack
-			</a>
-			. We're here to help!
+				reach out to us on Slack.
+			</a>{' '}
+			We're here to help!
 		</p>
 		<Spacer height={30} />
 		<Button className={styles.button} href="/Account">
diff --git a/src/packages/admin-ui-components/src/assets/16-search.tsx b/src/packages/admin-ui-components/src/assets/16-search.tsx
@@ -2,7 +2,7 @@ import { SVGProps } from 'react';
 
 export const SearchIcon = (props: SVGProps<SVGSVGElement>) => (
 	<svg width="16" height="16" viewBox="0 0 16 16" fill="none" {...props}>
-		<circle cx="7" cy="7" r="5" stroke="#918C99" stroke-width="2" />
+		<circle cx="7" cy="7" r="5" stroke="#918C99" strokeWidth="2" />
 		<path
 			d="M10.667 10.667L14.0003 14.0003"
 			stroke="#918C99"
diff --git a/src/packages/admin-ui-components/src/assets/close-button.tsx b/src/packages/admin-ui-components/src/assets/close-button.tsx
@@ -2,7 +2,7 @@ import { SVGProps } from 'react';
 
 export const CloseButtonIcon = (props: SVGProps<SVGSVGElement>) => (
 	<svg
-		enable-background="new 0 0 47.971 47.971"
+		enableBackground="new 0 0 47.971 47.971"
 		fill="#7038c2"
 		version="1.1"
 		viewBox="0 0 47.971 47.971"
diff --git a/src/packages/admin-ui-components/src/date-picker/styles.module.css b/src/packages/admin-ui-components/src/date-picker/styles.module.css
@@ -97,13 +97,11 @@
 	background-color: var(--select-background);
 	border: none;
 	min-height: 36px;
-	padding-top: 8px;
-	padding-left: 10px;
 	width: 100%;
 	white-space: nowrap;
 	overflow: hidden;
 	color: #6c757d;
-	padding: 5px 8px;
+	padding: 5px 8px 0 10px;
 }
 
 .inputFieldActive {
diff --git a/src/packages/admin-ui-components/src/default-error-fallback/component.tsx b/src/packages/admin-ui-components/src/default-error-fallback/component.tsx
@@ -50,9 +50,8 @@ export const DefaultErrorFallback = ({ error }: FallbackProps) => {
 							href="https://github.com/exogee-technology/graphweaver/issues/new/choose"
 							target="_blank"
 						>
-							open a GitHub issue
+							open a GitHub issue.
 						</a>
-						.
 					</p>
 					<Spacer height={40} />
 					<Button
diff --git a/src/packages/admin-ui-components/src/detail-panel-field-label/styles.module.css b/src/packages/admin-ui-components/src/detail-panel-field-label/styles.module.css
@@ -1,7 +1,7 @@
 .detailPanelFieldLabel {
 	flex: none;
 
-	font-family: 'Inter';
+	font-family: 'Inter', sans-serif;
 	font-style: normal;
 	font-size: 14px;
 	line-height: 150%;
@@ -12,7 +12,7 @@
 }
 
 .required {
-	font-family: 'Inter';
+	font-family: 'Inter', sans-serif;
 	font-style: normal;
 	font-size: 14px;
 	line-height: 150%;
diff --git a/src/packages/admin-ui-components/src/detail-panel/fields/rich-text-field/styles.module.css b/src/packages/admin-ui-components/src/detail-panel/fields/rich-text-field/styles.module.css
@@ -117,8 +117,6 @@
 }
 
 .richText :global .tiptap pre {
-	white-space: revert;
-	white-space: revert;
 	white-space: revert;
 	word-wrap: revert;
 }
diff --git a/src/packages/admin-ui-components/src/detail-panel/styles.module.css b/src/packages/admin-ui-components/src/detail-panel/styles.module.css
@@ -90,7 +90,7 @@
 	left: 32px;
 	top: 57px;
 
-	font-family: 'Inter';
+	font-family: 'Inter', sans-serif;
 	font-style: normal;
 	font-weight: 400;
 	font-size: 14px;
@@ -104,7 +104,7 @@
 	background: none !important;
 	border: none;
 	padding: 0 !important;
-	font-family: 'Inter';
+	font-family: 'Inter', sans-serif;
 	font-style: normal;
 	color: white;
 	text-decoration: underline;
diff --git a/src/packages/admin-ui-components/src/error-view/styles.module.css b/src/packages/admin-ui-components/src/error-view/styles.module.css
@@ -12,7 +12,7 @@
 }
 
 .title {
-	font-family: 'Inter';
+	font-family: 'Inter', sans-serif;
 	font-weight: 600;
 	font-size: 32px;
 	line-height: 140%;
diff --git a/src/packages/admin-ui-components/src/filters/numeric-range-filter/styles.module.css b/src/packages/admin-ui-components/src/filters/numeric-range-filter/styles.module.css
@@ -95,13 +95,11 @@
 	background-color: var(--select-background);
 	border: none;
 	min-height: 36px;
-	padding-top: 8px;
-	padding-left: 10px;
 	width: 100%;
 	white-space: nowrap;
 	overflow: hidden;
 	color: #6c757d;
-	padding: 5px 8px;
+	padding: 5px 8px 0 10px;
 }
 
 .inputFieldActive {
diff --git a/src/packages/admin-ui-components/src/layouts/default/styles.module.css b/src/packages/admin-ui-components/src/layouts/default/styles.module.css
@@ -35,7 +35,6 @@
 	padding: 20px;
 	flex-basis: 0;
 	flex-grow: 1;
-	min-width: 0;
 	display: flex;
 	flex-direction: column;
 	min-width: 380px;
diff --git a/src/packages/admin-ui-components/src/missing-entity/styles.module.css b/src/packages/admin-ui-components/src/missing-entity/styles.module.css
@@ -11,15 +11,15 @@
 }
 
 .heading {
-	font-family: 'Inter';
+	font-family: 'Inter', sans-serif;
 	font-weight: 600;
 	font-size: 32px;
 	line-height: 140%;
 	color: #ede8f2;
 }
 
 .text {
-	font-family: 'Inter';
+	font-family: 'Inter', sans-serif;
 	font-weight: 400;
 	font-size: 14px;
 	line-height: 150%;
diff --git a/src/packages/admin-ui-components/src/modal/component.tsx b/src/packages/admin-ui-components/src/modal/component.tsx
@@ -69,12 +69,16 @@ export const Modal = ({
 	return (
 		<>
 			{isOpen && (
-				<div ref={overlayRef} className={clsx(overlay ? styles.overlay : styles.noOverlay)}>
+				<div
+					ref={overlayRef}
+					className={clsx(overlay ? styles.overlay : styles.noOverlay)}
+					data-testid="modal-background"
+				>
 					<div
 						ref={modalRef}
 						className={clsx(className || [styles.wrapper, fullScreen && styles.fullScreen])}
 					>
-						<div className={styles.content}>
+						<div className={styles.content} data-testid="modal-content">
 							{title && (
 								<div className={styles.headerWrapper}>
 									<div className={styles.header}>
diff --git a/src/packages/admin-ui-components/src/modal/styles.module.css b/src/packages/admin-ui-components/src/modal/styles.module.css
@@ -90,7 +90,7 @@
 .title {
 	height: 25px;
 	align-self: center;
-	font-family: 'Inter';
+	font-family: 'Inter', sans-serif;
 	font-style: normal;
 	font-weight: 600;
 	font-size: 18px;
diff --git a/src/packages/admin-ui-components/src/popover/styles.module.css b/src/packages/admin-ui-components/src/popover/styles.module.css
@@ -28,7 +28,7 @@
 	flex-shrink: 0;
 	white-space: nowrap;
 
-	font-family: 'Inter';
+	font-family: 'Inter', sans-serif;
 
 	font-style: normal;
 	font-weight: 500;
@@ -79,7 +79,7 @@
 	flex-shrink: 0;
 	white-space: nowrap;
 
-	font-family: 'Inter';
+	font-family: 'Inter', sans-serif;
 
 	font-style: normal;
 	font-weight: 500;
diff --git a/src/packages/auth-ui-components/src/components/password/password/styles.module.css b/src/packages/auth-ui-components/src/components/password/password/styles.module.css
@@ -11,7 +11,7 @@
 .fieldLabel {
 	flex: none;
 
-	font-family: 'Inter';
+	font-family: 'Inter', sans-serif;
 	font-style: normal;
 	font-size: 14px;
 	line-height: 150%;
diff --git a/src/packages/auth-ui-components/src/components/secret/styles.module.css b/src/packages/auth-ui-components/src/components/secret/styles.module.css
@@ -19,7 +19,7 @@
 .fieldLabel {
 	flex: none;
 
-	font-family: 'Inter';
+	font-family: 'Inter', sans-serif;
 	font-style: normal;
 	font-size: 14px;
 	line-height: 150%;
diff --git a/src/packages/end-to-end/src/__tests__/ui/rest/basic-functionality.test.ts b/src/packages/end-to-end/src/__tests__/ui/rest/basic-functionality.test.ts
@@ -24,7 +24,7 @@ test('Ensure vehicles can be listed and that they have pilots', async ({ page })
 	await expect(page.getByTestId('detail-panel-field-pilots')).toContainText(
 		'pilots*Luke SkywalkerWedge Antilles'
 	);
-	await page.locator('._overlay_1slpl_1').click();
+	await page.getByTestId('modal-background').click();
 	await page.getByRole('cell', { name: 'AT-ST' }).click();
 	await expect(page.getByTestId('detail-panel-field-pilots')).toContainText('pilots*Chewbacca');
 });
diff --git a/src/packages/vite-plugin-graphweaver/src/loaders/csv-export-overrides.ts b/src/packages/vite-plugin-graphweaver/src/loaders/csv-export-overrides.ts
@@ -17,8 +17,8 @@ export const loadCsvExportOverrides = async (projectRoot: string) => {
 		// @todo Validate import- we can't import typescript here but we could validate another way
 
 		return `export { csvExportOverrides } from '${resolvedCsvExportOverridesPath}';`;
-	} catch (error: any) {
-		console.warn('No CSV export overrides found: ', error);
+	} catch {
+		console.warn('No CSV export overrides found.');
 		return `export const csvExportOverrides = {};`;
 	}
 };
