fix sgf, sieve and linked list exercise

Author: grzegorz-bielski

bin/test-in-docker

@@ -47,12 +47,12 @@ object Sgf extends RegexParsers {
 
   private val propValue: Parser[String] =
     "[" ~ rep1(propValuePart) ~ "]" ^^ {
-      case _ ~ values ~ _ => values mkString
+      case _ ~ values ~ _ => values.mkString
     } named "propValue"
 
   private val propValuePart: Parser[String] = {
     implicit class AsStringParser(self: String) { def p: Parser[String] = self }
-    val ignore = const("") _
+    val ignore = const("")
 
     val escapedNewline: Parser[String] = "\\\n".p ^^ ignore
     val escapedChar: Parser[String] = """\\.""".r ^^ (_.takeRight(1))

exercises/practice/sgf-parsing/.meta/Example.scala

@@ -6,7 +6,7 @@ object Sieve {
     val primes = mutable.HashSet.empty ++ (2 to upperBound)
 
     // Remove multiples of a possiblePrime from the primes set.
-    def checkPrime(possiblePrime: Int) {
+    def checkPrime(possiblePrime: Int) = {
       if (primes contains possiblePrime) {
         // remove multiples of possiblePrime from set
         val possibleSquared = possiblePrime * possiblePrime

exercises/practice/sieve/.meta/Example.scala

@@ -65,21 +65,21 @@ class SimpleLinkedListTest extends AnyFlatSpec with Matchers with ScalaCheckDriv
 
   it should "handle arbitrary list fromSeq toSeq" in {
     pending
-    forAll { seq: Seq[Int] =>
+    forAll { (seq: Seq[Int]) =>
       assert(SimpleLinkedList.fromSeq(seq).toSeq == seq)
     }
   }
 
   it should "handle reverse arbitrary list " in {
     pending
-    forAll { seq: Seq[Int] =>
+    forAll { (seq: Seq[Int]) =>
       assert(SimpleLinkedList.fromSeq(seq).reverse.toSeq == seq.reverse)
     }
   }
 
   it should "reverse arbitrary list back to original" in {
     pending
-    forAll { list: SimpleLinkedList[Int] =>
+    forAll { (list: SimpleLinkedList[Int]) =>
       assert(list.reverse.reverse.toSeq == list.toSeq)
     }
   }
@@ -90,7 +90,7 @@ class SimpleLinkedListTest extends AnyFlatSpec with Matchers with ScalaCheckDriv
       (0 until i).foldLeft(list)((acc, j) => acc.next).value
     }
 
-    forAll { xs: Seq[Int]  =>
+    forAll { (xs: Seq[Int]) =>
       whenever(xs.nonEmpty) {
         val list = SimpleLinkedList.fromSeq(xs)
         xs.indices.foreach {
@@ -102,15 +102,15 @@ class SimpleLinkedListTest extends AnyFlatSpec with Matchers with ScalaCheckDriv
 
   it should "return original arbitrary list from added list elements" in {
     pending
-    forAll { xs: Seq[Int] =>
+    forAll { (xs: Seq[Int]) =>
       val list = xs.foldLeft(SimpleLinkedList[Int]())(_.add(_))
       assert(list.toSeq == xs)
     }
   }
 
   it should "handle arbitrary generics" in {
     pending
-    forAll { xs: Seq[String] =>
+    forAll { (xs: Seq[String]) =>
       assert(SimpleLinkedList.fromSeq(xs).toSeq == xs)
     }
   }