DEVPROD-27645: Optimize lint-staged to only run schema check on GraphQL changes#1350
Open
khelif96 wants to merge 1 commit intoevergreen-ci:mainfrom
Open
DEVPROD-27645: Optimize lint-staged to only run schema check on GraphQL changes#1350khelif96 wants to merge 1 commit intoevergreen-ci:mainfrom
khelif96 wants to merge 1 commit intoevergreen-ci:mainfrom
Conversation
sophstad
reviewed
Feb 6, 2026
Contributor
sophstad
left a comment
sophstad
left a comment
There was a problem hiding this comment.
I'm not sure this is desirable if we're still going to run check_codegen on every job; this just delays the signal that your codegen needs updating which may be frustrating.
What do you think of also only running check_codegen when there are GraphQL changes? If this is successful, we could also remove it from the waterfall (but perhaps not just yet because that seems like removing a lot of signal at once).
Contributor
Author
|
Ok good point, How about 1 better and have a pr auto get created to bump types so that the types are always created and if someone takes a bit longer to merge their generated types every other user doesn't have to manually gen them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR the check-schema-and-codegen lint task really annoyed me by being so slow so now it only runs on graphql changes
Summary
check-schema-and-codegenonly on.graphqlfile changes instead of all TypeScript files.ts/.tsxfile change, which was inefficient since:check_codegentaskTest plan
check-schema-and-codegenwhen modifying.graphqlfiles.ts/.tsxfiles🤖 Generated with Claude Code