core/state: cache missing storage entries (#16584)

fjl · gbalint · commit c1f1418a5346 · 2018-05-23T12:00:21.000+02:00
diff --git a/core/state/state_object.go b/core/state/state_object.go
@@ -178,9 +178,7 @@ func (self *stateObject) GetState(db Database, key common.Hash) common.Hash {
 		}
 		value.SetBytes(content)
 	}
-	if (value != common.Hash{}) {
-		self.cachedStorage[key] = value
-	}
+	self.cachedStorage[key] = value
 	return value
 }
 
@@ -197,7 +195,6 @@ func (self *stateObject) SetState(db Database, key, value common.Hash) {
 func (self *stateObject) setState(key, value common.Hash) {
 	self.cachedStorage[key] = value
 	self.dirtyStorage[key] = value
-
 }
 
 // updateTrie writes cached storage modifications into the object's storage trie.

Original file line number	Diff line number	Diff line change
`@@ -178,9 +178,7 @@ func (self *stateObject) GetState(db Database, key common.Hash) common.Hash {`
`178`	`178`	`}`
`179`	`179`	`value.SetBytes(content)`
`180`	`180`	`}`
`181`		`- if (value != common.Hash{}) {`
`182`		`- self.cachedStorage[key] = value`
`183`		`- }`
	`181`	`+ self.cachedStorage[key] = value`
`184`	`182`	`return value`
`185`	`183`	`}`
`186`	`184`
`@@ -197,7 +195,6 @@ func (self *stateObject) SetState(db Database, key, value common.Hash) {`
`197`	`195`	`func (self *stateObject) setState(key, value common.Hash) {`
`198`	`196`	`self.cachedStorage[key] = value`
`199`	`197`	`self.dirtyStorage[key] = value`
`200`		`-`
`201`	`198`	`}`
`202`	`199`
`203`	`200`	`// updateTrie writes cached storage modifications into the object's storage trie.`