evm: fix 3860 implementation + tests #2397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 EthereumJS Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
holgerd77
reviewed
Nov 4, 2022
| ) | ||
| st.end() | ||
| }) | ||
| }) |
jochem-brouwer
added a commit
that referenced
this pull request
Nov 4, 2022
* evm: fix 3860 implementation + tests * Adapt original EIP-3860 tests from vm * add test for Create2 * Add test for CREATE Co-authored-by: acolytec3 <[email protected]>
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our EIP 3860 implementation, we have not added this rule:
"Furthermore, we introduce a charge of
2gas for every 32-byte chunk ofinitcodeto represent the cost of jumpdest-analysis."This /does/ happen at
CREATEs at the tx-level, but it does not happen if we have aCREATEor aCREATE2This also passes the current ethereum/tests tests for EIP 3860.
To check:
All pass.
Note: problem found by @pk910 in block 6601 on the Shandong testnet.