Skip to content

feat: add affected_by_radius to content key#1839

Merged
morph-dev merged 1 commit into
ethereum:masterfrom
morph-dev:key_radius
May 19, 2025
Merged

feat: add affected_by_radius to content key#1839
morph-dev merged 1 commit into
ethereum:masterfrom
morph-dev:key_radius

Conversation

@morph-dev
Copy link
Copy Markdown
Collaborator

@morph-dev morph-dev commented May 19, 2025

What was wrong?

We currently have no way to differentiate between content that:

  • is affected by distance from node_id (i.e. non-ephemeral history + state)
  • is not affected by distance from node_id (i.e. ephemeral history + beacon)

This affects how we:

  • decide whether to accept and store content
  • select peers to ask for content (during find_content)
  • select peers to gossip content to (both during gossip and poke)
    • we don't do random content correctly at the moment

How was it fixed?

Added affected_by_radius function on OverlayContentKey trait.
This PR sets up ground work for implementing most missing functionality, which can be split into 3 main categories that will be done in a followup PR:

To-Do

Copy link
Copy Markdown
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: looks good

@morph-dev morph-dev merged commit 57ada36 into ethereum:master May 19, 2025
16 checks passed
@morph-dev morph-dev deleted the key_radius branch May 19, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants