chore: bump dependencies#1834
Conversation
KolbyML
force-pushed
the
update-dependencies
branch
from
d92b9ea to
18f429f
Compare
| #[cfg(test)] | ||
| mod tests { | ||
| use std::{str::FromStr, sync::Arc}; | ||
| use std::{result::Result::Ok, str::FromStr, sync::Arc}; |
There was a problem hiding this comment.
Why do we have to import Ok?
There was a problem hiding this comment.
traced_test throws this error unless we import it
There was a problem hiding this comment.
I removed the import, by just adding an empty anyhow result as the return type
There was a problem hiding this comment.
Do we even need traced_test and why?
Reading at documentation,my understanding is that it's used so you can assert that certain logs were/weren't logged, and I don't think we are doing that. What am I missing?
There was a problem hiding this comment.
This is the documentation that I was looking at: https://docs.rs/tracing-test/latest/tracing_test/index.html
There was a problem hiding this comment.
I don't know why it is there to be honest
There was a problem hiding this comment.
Yeah I was able to remove it without issues
| let git2 = Git2Builder::default() | ||
| .describe(false, true, None) | ||
| .dirty(true) | ||
| .sha(false) |
There was a problem hiding this comment.
This used to be true. Was change intentional?
There was a problem hiding this comment.
The true condition doesn't enable anything we use from my testing
| .build()?; | ||
| let git2 = Git2Builder::default() | ||
| .describe(false, true, None) | ||
| .dirty(true) |
There was a problem hiding this comment.
We didn't use this before. Why do we need it now?
There was a problem hiding this comment.
If I don't have this line the build script fails
There was a problem hiding this comment.
I am assuming it enables a few environment variables we need
| tree_hash_derive = "0.10" | ||
| uds_windows = "1.0.1" | ||
| ureq = { version = "2.5.0", features = ["json"] } | ||
| ureq = { version = "3.0", features = ["json"] } |
There was a problem hiding this comment.
I think you removed all usage of ureq. Should we just remove it?
2 participants
What was wrong?
We haven't updated most of our dependencies in a long long time
How was it fixed?
bump most of them
I left 2I left 1
- vergen as updating it is a little involved as they almost redid the libraries interface, so probably best for a future PRvergen wasn't that bad I will include it in this PR