feat: validate blocks while building E2HS file#1808
Merged
Conversation
morph-dev
reviewed
May 6, 2025
Collaborator
morph-dev
left a comment
morph-dev
left a comment
There was a problem hiding this comment.
🚢
It would be good if you would locally verify that this works for fork boundary e2hs files.
morph-dev
approved these changes
May 6, 2025
Member
Author
|
I tested the fork boundry for capellia and it worked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Building E2HS files is time consuming. There isn't a good way for the bridge to validate post-capella headers due to the E2HS bridge not having access to a provider. We want to know sooner then later if a E2HS file is valid or not.
How was it fixed?
Validate the block, use the latest HistoricalSummaries if avaliable, if HistoricalSummaries aren't avaliable there are no post capella headers to prove so there is no issue.