fix: update bootnodes#1806
Merged
Merged
Conversation
Member
I am confused, in version 1 we didn't change anything with LightClientBootstraps right? How would bootnodes reporting v0 cause a failure? Also we support version 0 and version 1. |
looks good
Collaborator
Author
We discussed it and I updated the PR description to explain it better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Our bootnodes are outdated and they contain v0 protocol version.
This would usually not be a problem, but they store beacon content and they are the first one that we contact during light-client sync (because we start light-client syncing before everything else, so they are the only one we know about at that point), and we assume protocol v0 version and fail to decode the content.
Technically, this shouldn't happen even with this setup, as we should get new Enr when discv5 session is established.
I didn't investigate but I suspect that "Request" object still has old Enr and that's what it uses to decode the response.
How was it fixed?
Updated bootnode Enrs according to glados.
To-Do