fix: stop bridging content to nodes outside their radius#1792
Merged
KolbyML merged 1 commit intoApr 29, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
After I implemented AcceptCodes I found we had a bug in our Bridge. We should never offer content to Nodes if we know it outside of their radius, as this is just wasted resources, which for a bridge resources are limited. #1773
I was just testing the bridge and I noticed it again.
How was it fixed?
By adding a filter to only include nodes with a weight over 0.
choose_multiple_weighted()will include peers with 0 weight, if there are less thenamountof nodes with a weight of over 0. We don't want to gossip to though peers though as we already know they won't accept the content. We can instead offer other content to other nodes which will accept the content.