Skip to content

feat: change EnrOfferLimit from 2 to 8#1771

Merged
KolbyML merged 2 commits into
ethereum:masterfrom
KolbyML:set-default-to-8
Apr 22, 2025
Merged

feat: change EnrOfferLimit from 2 to 8#1771
KolbyML merged 2 commits into
ethereum:masterfrom
KolbyML:set-default-to-8

Conversation

@KolbyML
Copy link
Copy Markdown
Member

@KolbyML KolbyML commented Apr 21, 2025

What was wrong?

Today in the call I said I would add the granular offer code I wrote for the StateBridge to the E2HS bridge, but after thinking about that I think that would be completely overkill, expessially when the History Network has 100-1000x less content for us to offer.

Because long term the state bridge won't be apart of portal-bridge and I am already running the 4 E2HS bridges I am running with --enr-offer-limit=8 with good results. I think just increasing the default is good enough for the E2HS bridge

How was it fixed?

changed the default limit from 2 to 8. It isn't worth the additional complexity, as the E2HS bridge doesn't face the same challenges which warrant it

@KolbyML KolbyML requested a review from morph-dev April 21, 2025 23:39
@KolbyML KolbyML self-assigned this Apr 21, 2025
Copy link
Copy Markdown
Collaborator

@morph-dev morph-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Comment thread bin/portal-bridge/src/cli.rs Outdated
Comment on lines +35 to +37
/// The maximum number of enrs to return in a response,
/// limiting the number of OFFER requests spawned by the bridge
/// for each piece of content
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// The maximum number of enrs to return in a response,
/// limiting the number of OFFER requests spawned by the bridge
/// for each piece of content
/// The maximum number of peers to send each piece of content.
///
/// This is used as a parameter in census, which selects the peers.

nit: I think this comment was written mostly from census point of view, and now is a bit outdated. Feel free to update it.

@KolbyML KolbyML merged commit 37a8be4 into ethereum:master Apr 22, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants