feat: change EnrOfferLimit from 2 to 8#1771
Merged
Merged
Conversation
morph-dev
approved these changes
Apr 22, 2025
Comment on lines
+35
to
+37
| /// The maximum number of enrs to return in a response, | ||
| /// limiting the number of OFFER requests spawned by the bridge | ||
| /// for each piece of content |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// The maximum number of enrs to return in a response, | |
| /// limiting the number of OFFER requests spawned by the bridge | |
| /// for each piece of content | |
| /// The maximum number of peers to send each piece of content. | |
| /// | |
| /// This is used as a parameter in census, which selects the peers. |
nit: I think this comment was written mostly from census point of view, and now is a bit outdated. Feel free to update it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Today in the call I said I would add the granular offer code I wrote for the StateBridge to the E2HS bridge, but after thinking about that I think that would be completely overkill, expessially when the History Network has 100-1000x less content for us to offer.
Because long term the state bridge won't be apart of
portal-bridgeand I am already running the 4 E2HS bridges I am running with--enr-offer-limit=8with good results. I think just increasing the default is good enough for the E2HS bridgeHow was it fixed?
changed the default limit from 2 to 8. It isn't worth the additional complexity, as the E2HS bridge doesn't face the same challenges which warrant it