chore: fix clippy warnings on cargo update#1744
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses Clippy warnings encountered during the weekly cargo update by updating format strings in log messages.
- Update format string syntax across log messages in the light-client RPC and client modules
- Replace traditional formatting placeholders with in-string interpolation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/light-client/src/rpc.rs | Updated the log message string interpolation style |
| crates/light-client/src/client.rs | Updated log messages to use in-string interpolation for errors and checkpoint responses |
Comments suppressed due to low confidence (1)
crates/light-client/src/client.rs:417
- Consider using debug formatting (i.e. {checkpoint:?}) if the checkpoint is intended to be formatted with Debug, to preserve the original output style.
info!("external fallbacks responded with checkpoint {checkpoint}",);
Comment on lines
383
to
384
| info!("external fallbacks responded with checkpoint 0x{checkpoint}",); | ||
|
|
There was a problem hiding this comment.
Consider using debug formatting (i.e. {checkpoint:?}) instead of the default display formatting if checkpoint requires Debug output, to match previous behavior.
Suggested change
| info!("external fallbacks responded with checkpoint 0x{checkpoint}",); | |
| info!("external fallbacks responded with checkpoint 0x{checkpoint:?}",); |
Member
Author
There was a problem hiding this comment.
Here, we don't require debug output.
KolbyML
approved these changes
Apr 4, 2025
bd9d6c9 to
3cc149f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Clippy check fails on the automatic weekly cargo update action: #1737
How was it fixed?
cargo updatemanuallyTo-Do