refactor: print debug logs for silent errors in handle_offer()#1734
Merged
Conversation
KolbyML
requested review from
carver,
morph-dev,
mrferris,
njgheorghita and
ogenev
morph-dev
approved these changes
Mar 28, 2025
| key, utp_processing, | ||
| ) | ||
| .await { | ||
| debug!(%err, "Fallback FINDCONTENT task failed, after validating and storing content failed"); |
Collaborator
There was a problem hiding this comment.
nit: maybe add content key here as well?
| ) | ||
| .await; | ||
| .await { | ||
| debug!(%err, content_key = ?content_key, "Fallback FINDCONTENT task failed, after uTP transfer failed"); |
Collaborator
There was a problem hiding this comment.
Suggested change
| debug!(%err, content_key = ?content_key, "Fallback FINDCONTENT task failed, after uTP transfer failed"); | |
| debug!(%err, ?content_key, "Fallback FINDCONTENT task failed, after uTP transfer failed"); |
nit: I think this would work. Same at line 1164
ogenev
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
The Samba team has spent days trying to debug why there
put_contentimplementation isn't working, Trin wasn't printing any logs so they had no way to tell why Trin was failing to accept their offerHow was it fixed?
If these functions return error's print them on the debug log