Add workspace name to tabs #974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioedeveloper
force-pushed
the
blank-tabs
branch
from
c7de04f to
c2326c4
Compare
LianaHus
reviewed
Mar 15, 2021
| }) | ||
| } | ||
|
|
||
| getCurrentWorkspace () { |
Contributor
There was a problem hiding this comment.
Maybe currentWorkspace() ? Just a suggestion
ioedeveloper
force-pushed
the
blank-tabs
branch
from
c2326c4 to
f3175b6
Compare
yann300
reviewed
Mar 15, 2021
|
|
||
| currentWorkspace () { | ||
| const file = this.currentFile() || '' | ||
| const provider = this.fileProviderOf(file) |
Contributor
There was a problem hiding this comment.
Here you could just do
const provider = self._deps.filesProviders.workspace
because anyway, the localhost provider doesn't have the workspace property
ioedeveloper
force-pushed
the
blank-tabs
branch
from
0969366 to
469c3fe
Compare
ryestew
reviewed
Mar 16, 2021
yann300
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #967