Throw if no workspace #933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
force-pushed
the
throwIfNoWorkspace
branch
from
c7f321b to
2174d84
Compare
yann300
force-pushed
the
throwIfNoWorkspace
branch
from
9361b8b to
cac3401
Compare
LianaHus
reviewed
Mar 3, 2021
| const provider = fileManager.getProvider('workspace') | ||
| provider.lastLoadedGistId = gistId | ||
| } else { | ||
| modalDialogCustom.alert(errorLoadingFile.message || errorLoadingFile) |
Contributor
There was a problem hiding this comment.
Please add a title to the modal, looks kind of unfinished without.
Contributor
Author
There was a problem hiding this comment.
I can update those, but most of the custom alert doesn't set any title..
Contributor
There was a problem hiding this comment.
I know. I'm putting everywhere now. Looks better
LianaHus
reviewed
Mar 3, 2021
| alert: function (title, text) { | ||
| if (text) return modal(title, yo`<div>${text}</div>`, null, { label: null }) | ||
| return modal('', yo`<div>${title}</div>`, null, { label: null }) | ||
| return modal('alert', yo`<div>${title}</div>`, null, { label: null }) |
yann300
force-pushed
the
throwIfNoWorkspace
branch
2 times, most recently
from
af63d1e to
86d4a9c
Compare
yann300
force-pushed
the
throwIfNoWorkspace
branch
from
86d4a9c to
d3b9305
Compare
yann300
force-pushed
the
throwIfNoWorkspace
branch
from
0a63fd2 to
77925a0
Compare
yann300
force-pushed
the
throwIfNoWorkspace
branch
from
a7c9c05 to
a0d1fcc
Compare
Aniket-Engg
approved these changes
Mar 4, 2021
ioedeveloper
approved these changes
Mar 4, 2021
yann300
force-pushed
the
throwIfNoWorkspace
branch
from
5639713 to
aaeea9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This throws an exception while using file manager and file provider if no workspace has been set.