package asset (theme files) #653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
force-pushed
the
offlineVersion
branch
3 times, most recently
from
cb81d72 to
3ab2aee
Compare
yann300
force-pushed
the
offlineVersion
branch
from
3ab2aee to
0b35da0
Compare
LianaHus
reviewed
Dec 8, 2020
| this._view.versionSelector = yo` | ||
| <select onchange="${this.onchangeLoadVersion.bind(this)}" class="custom-select" id="versionSelector" disabled> | ||
| <option disabled selected>${this.data.defaultVersion}</option> | ||
| <option disabled>builtin</option> |
Contributor
There was a problem hiding this comment.
can we put a version here? Is this used for offline one?
LianaHus
reviewed
Dec 8, 2020
| async fetchAllVersion (callback) { | ||
| let allVersions, selectedVersion, allVersionsWasm, isURL | ||
| let selectedVersion, allVersionsWasm, isURL | ||
| let allVersions = [{ path: 'builtin', longVersion: 'latest local version' }] |
Contributor
There was a problem hiding this comment.
Can we put a exact version here? "Latest local (v0.10.12)"
Contributor
Author
There was a problem hiding this comment.
we don't know before hand which version will be loaded cause it is the one located in the asset folder, we could hardcode it, we'll need to change it each time we put a new version in the asset
LianaHus
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #402
partially_fix #403 with "offline compiler"