Added expected vs received values for tests in SUT plugin #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LianaHus
changed the title
ioedeveloper
requested changes
Sep 4, 2020
| </div> | ||
| <span class="text-dark">Received value:</span> | ||
| <span>${result.returned}</span> | ||
| <span class="text-dark text-sm pb-2">Skipping the rest...</span> |
Collaborator
There was a problem hiding this comment.
Skipping the rest... is not so informative. I think Skipping remaining tests will provide better info.
Contributor
Author
There was a problem hiding this comment.
should it be skipping the remaining tests of a function? or without function?
Collaborator
There was a problem hiding this comment.
I think, we can update the text as : Skipping the remaining tests of the function => Skipping the remaining tests...
Because we already show tests corresponding to a function in a box
Collaborator
There was a problem hiding this comment.
@ioedeveloper I think this text has not been changed yet
ioedeveloper
requested changes
Sep 4, 2020
ioedeveloper
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.