Moved E2E Tests To Typescript #343
Conversation
ioedeveloper
requested review from
Aniket-Engg,
GrandSchtroumpf,
LianaHus and
yann300
ioedeveloper
force-pushed
the
nightwatch-ts
branch
from
0ed1bdb to
7469a0f
Compare
| class addAtAddressInstance extends EventEmitter { | ||
| command (address, isValidFormat, isValidChecksum) { | ||
| this.api.perform((done) => { | ||
| command (this: NightwatchBrowser, address: string, isValidFormat: boolean, isValidChecksum: boolean): NightwatchBrowser { |
There was a problem hiding this comment.
sounds like risky to name a variable this, could be addressed in an another PR..
There was a problem hiding this comment.
It is not a variable. this is the context which the command function uses. It is normally passed by the caller of the command function from nightwatch. Also, passing parameters into the command function without specifying this works perfectly. It just uses the default context for this which is the addAtAddressInstance class for this example.
| @@ -0,0 +1,20 @@ | |||
| <?xml version="1.0" encoding="UTF-8" ?> | |||
There was a problem hiding this comment.
can we remove all the reports files or is this necessary to keep them?
There was a problem hiding this comment.
Yeah, we don't need the report files. But git ignores the directories during commit because they are empty. We will need something in it at least to get git to commit the directory.
… to new selenium config
ioedeveloper
force-pushed
the
nightwatch-ts
branch
from
62de69a to
47da15d
Compare
No description provided.