cmd/utils: reuse existing genesis in persistent dev mode #21352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Merging this as got a confirm from the issue author that the PR fixes the problem. Also it's more or less a trivial change. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21323 (comment).
We've updated the dev mode genesis block to seed some new precompiles. Unfortunately, in dev mode with persistent database we didn't load the genesis from disk, rather always regenerated it and it just happened to match the one on disk. With the changed seeding, any old persisted dev chain became unloadable because of a genesis mismatch.
This PR fixes it by checking the provided data directory for an already initialized chain, and if so, dev mode uses that and does not try to generate a new genesis spec.