eth/protocols/eth: fix announced tx size wrt type byte

karalabe · karalabe · commit fc583202f245 · 2022-10-26T15:58:01.000+03:00
diff --git a/eth/protocols/eth/broadcast.go b/eth/protocols/eth/broadcast.go
@@ -152,7 +152,7 @@ func (p *Peer) announceTransactions() {
 				if tx := p.txpool.Get(queue[count]); tx != nil {
 					pending = append(pending, queue[count])
 					pendingTypes = append(pendingTypes, tx.Type())
-					pendingSizes = append(pendingSizes, 1+uint32(tx.Size())) // txsize += 1 because of txtype byte
+					pendingSizes = append(pendingSizes, uint32(tx.Size()))
 					size += common.HashLength
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ func (p *Peer) announceTransactions() {`
`152`	`152`	`if tx := p.txpool.Get(queue[count]); tx != nil {`
`153`	`153`	`pending = append(pending, queue[count])`
`154`	`154`	`pendingTypes = append(pendingTypes, tx.Type())`
`155`		`- pendingSizes = append(pendingSizes, 1+uint32(tx.Size())) // txsize += 1 because of txtype byte`
	`155`	`+ pendingSizes = append(pendingSizes, uint32(tx.Size()))`
`156`	`156`	`size += common.HashLength`
`157`	`157`	`}`
`158`	`158`	`}`