Skip to content

Conversation

@gurukamath
Copy link
Contributor

@gurukamath gurukamath commented Nov 26, 2025

🗒️ Description

In a recent commit, the FORK_CRITERIA declarations from:
FORK_CRITERIA = ByTimestamp(...) (simple assignment → cst.Assign node)
To: FORK_CRITERIA: ForkCriteria = ByTimestamp(...) (annotated assignment → cst.AnnAssign node)

The SetConstantCommand codemod in constant.py only handled Assign nodes, not AnnAssign nodes, so it couldn't replace the fork criteria value.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

3396657

@SamWilsn SamWilsn merged commit 916ddbb into ethereum:forks/osaka Nov 26, 2025
8 of 9 checks passed
@danceratopz danceratopz mentioned this pull request Nov 27, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants