Skip to content

tests/cancun/eip4844: Fix invalid blob gas fee transaction test #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

tests/cancun/eip4844: Fix invalid blob gas fee transaction test #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b02f6fe
tests/cancun/eip4844: fix invalid blob gas fee tx test
marioevz Dec 6, 2023
bc7c5d6
changelog
marioevz Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ Test fixtures for use by clients are available for each release on the [Github r

### 🧪 Test Cases

- 🐞 Fixed `tests/cancun/eip4844_blobs/test_blob_txs.py:test_invalid_tx_max_fee_per_blob_gas` to account for extra gas required in the case where the account is incorrectly deduced the balance as if it had the correct block blob gas fee.

### 🛠️ Framework

- ✨ Add a `--single-fixture-per-file` flag to generate one fixture JSON file per test case ([#331](https://github.com/ethereum/execution-spec-tests/pull/331)).
Expand Down
4 changes: 4 additions & 0 deletions tests/cancun/eip4844_blobs/test_blob_txs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,6 +516,10 @@ def test_valid_blob_tx_combinations(
],
ids=["insufficient_max_fee_per_blob_gas", "invalid_max_fee_per_blob_gas"],
)
@pytest.mark.parametrize(
"account_balance_modifier",
[1_000_000_000],
) # Extra balance to cover block blob gas cost
@pytest.mark.valid_from("Cancun")
def test_invalid_tx_max_fee_per_blob_gas(
blockchain_test: BlockchainTestFiller,
Expand Down