From b02f6fe21fe3455248bac9f02d2bc393bba33768 Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Wed, 6 Dec 2023 18:14:20 +0000 Subject: [PATCH 1/2] tests/cancun/eip4844: fix invalid blob gas fee tx test --- tests/cancun/eip4844_blobs/test_blob_txs.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/cancun/eip4844_blobs/test_blob_txs.py b/tests/cancun/eip4844_blobs/test_blob_txs.py index 5ae5db4f339..9d7f9d295b2 100644 --- a/tests/cancun/eip4844_blobs/test_blob_txs.py +++ b/tests/cancun/eip4844_blobs/test_blob_txs.py @@ -516,6 +516,10 @@ def test_valid_blob_tx_combinations( ], ids=["insufficient_max_fee_per_blob_gas", "invalid_max_fee_per_blob_gas"], ) +@pytest.mark.parametrize( + "account_balance_modifier", + [1_000_000_000], +) # Extra balance to cover block blob gas cost @pytest.mark.valid_from("Cancun") def test_invalid_tx_max_fee_per_blob_gas( blockchain_test: BlockchainTestFiller, From bc7c5d697acb2ec387bd9a5a9fe903e1aff8625e Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Wed, 6 Dec 2023 18:19:38 +0000 Subject: [PATCH 2/2] changelog --- docs/CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index f37279af44f..2136ef795d1 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -8,6 +8,8 @@ Test fixtures for use by clients are available for each release on the [Github r ### ๐Ÿงช Test Cases +- ๐Ÿž Fixed `tests/cancun/eip4844_blobs/test_blob_txs.py:test_invalid_tx_max_fee_per_blob_gas` to account for extra gas required in the case where the account is incorrectly deduced the balance as if it had the correct block blob gas fee. + ### ๐Ÿ› ๏ธ Framework - โœจ Add a `--single-fixture-per-file` flag to generate one fixture JSON file per test case ([#331](https://github.com/ethereum/execution-spec-tests/pull/331)).