Skip to content

RLP encoding and MPT hash calculation for Transaction and TransactionReceipt#569

Merged
rodiazet merged 4 commits into
masterfrom
tx-to-rlp
Feb 24, 2023
Merged

RLP encoding and MPT hash calculation for Transaction and TransactionReceipt#569
rodiazet merged 4 commits into
masterfrom
tx-to-rlp

Conversation

@rodiazet
Copy link
Copy Markdown
Member

@rodiazet rodiazet commented Feb 17, 2023

No description provided.

@rodiazet rodiazet requested review from axic and gumb0 February 17, 2023 18:46
@rodiazet rodiazet force-pushed the tx-to-rlp branch 2 times, most recently from f8b76a1 to 6e1da65 Compare February 17, 2023 18:49
axic
axic reviewed Feb 17, 2023
View reviewed changes
Comment thread test/statetest/statetest_loader.cpp Outdated
@axic axic changed the title rpl encoding and mtp hash calculation for Transaction and TransactionReceipt RLP encoding and MPT hash calculation for Transaction and TransactionReceipt Feb 17, 2023
@rodiazet rodiazet force-pushed the tx-to-rlp branch 2 times, most recently from 1d959d2 to bee6db1 Compare February 17, 2023 20:12
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 17, 2023 •
edited
Loading

Codecov Report

Merging #569 (83e94c9) into master (8e22572) will increase coverage by 0.08%.
The diff coverage is 98.92%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
+ Coverage   96.95%   97.03%   +0.08%     
==========================================
  Files          67       70       +3     
  Lines        6232     6505     +273     
==========================================
+ Hits         6042     6312     +270     
- Misses        190      193       +3
Flag Coverage Δ
blockchaintests 75.48% <ø> (ø)
statetests 69.50% <30.76%> (-1.45%) ⬇️
unittests 93.17% <99.27%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/state/state.hpp 96.29% <ø> (ø)
test/statetest/statetest_logs_hash.cpp 100.00% <ø> (ø)
test/state/bloom_filter.hpp 50.00% <50.00%> (ø)
test/state/state.cpp 98.24% <95.65%> (-0.68%) ⬇️
test/unittests/state_mpt_hash_test.cpp 98.91% <98.27%> (-1.09%) ⬇️
test/state/bloom_filter.cpp 100.00% <100.00%> (ø)
test/state/mpt_hash.cpp 100.00% <100.00%> (ø)
test/statetest/statetest_loader.cpp 77.47% <100.00%> (+1.17%) ⬆️
test/unittests/state_bloom_filter_test.cpp 100.00% <100.00%> (ø)
test/unittests/state_rlp_test.cpp 100.00% <100.00%> (ø)
... and 2 more

axic
axic reviewed Feb 17, 2023
View reviewed changes
Comment thread test/statetest/statetest_loader.cpp Outdated
axic
axic reviewed Feb 17, 2023
View reviewed changes
Comment thread test/state/bloom.cpp Outdated
axic
axic reviewed Feb 17, 2023
View reviewed changes
Comment thread test/state/bloom.cpp Outdated
axic
axic reviewed Feb 17, 2023
View reviewed changes
Comment thread test/state/bloom.cpp Outdated
axic
axic reviewed Feb 17, 2023
View reviewed changes
Comment thread test/state/bloom.cpp Outdated
axic
axic reviewed Feb 17, 2023
View reviewed changes
Comment thread test/state/bloom.hpp Outdated
axic
axic reviewed Feb 17, 2023
View reviewed changes
Comment thread test/state/mpt_hash.cpp Outdated
axic
axic reviewed Feb 17, 2023
View reviewed changes
Comment thread test/state/rlp.cpp Outdated
axic
axic reviewed Feb 17, 2023
View reviewed changes
Comment thread test/state/rlp.cpp Outdated
axic
axic reviewed Feb 17, 2023
View reviewed changes
Comment thread test/t8n/t8n.cpp
axic
axic reviewed Feb 20, 2023
View reviewed changes
Comment thread test/state/bloom.cpp Outdated
axic
axic reviewed Feb 20, 2023
View reviewed changes
Comment thread test/state/mpt_hash.hpp
axic
axic reviewed Feb 20, 2023
View reviewed changes
Comment thread test/state/mpt_hash.hpp Outdated
axic
axic reviewed Feb 20, 2023
View reviewed changes
Comment thread test/state/state.cpp Outdated
axic
axic reviewed Feb 20, 2023
View reviewed changes
Comment thread test/state/state.cpp Outdated
axic
axic reviewed Feb 20, 2023
View reviewed changes
Comment thread test/t8n/t8n.cpp Outdated
gumb0
gumb0 reviewed Feb 20, 2023
View reviewed changes
Comment thread test/state/mpt_hash.hpp Outdated
gumb0
gumb0 reviewed Feb 20, 2023
View reviewed changes
Comment thread test/state/mpt_hash.hpp Outdated
gumb0
gumb0 reviewed Feb 20, 2023
View reviewed changes
Comment thread test/state/mpt_hash.hpp Outdated
gumb0
gumb0 reviewed Feb 20, 2023
View reviewed changes
Comment thread test/state/state.hpp Outdated
gumb0
gumb0 reviewed Feb 20, 2023
View reviewed changes
Comment thread test/state/state.hpp Outdated
@rodiazet rodiazet requested a review from chfast February 23, 2023 13:11
chfast
chfast reviewed Feb 23, 2023
View reviewed changes
Comment thread test/statetest/statetest_loader.cpp
@rodiazet rodiazet force-pushed the tx-to-rlp branch 10 times, most recently from ebcd4c7 to 58110ac Compare February 24, 2023 15:15
@rodiazet rodiazet requested a review from chfast February 24, 2023 15:17
chfast
chfast reviewed Feb 24, 2023
View reviewed changes
Comment thread test/state/state.cpp Outdated
Comment thread test/state/state.cpp
chfast
chfast reviewed Feb 24, 2023
View reviewed changes
Comment thread test/unittests/state_bloom_filter_test.cpp Outdated
@rodiazet rodiazet force-pushed the tx-to-rlp branch 3 times, most recently from 957a22a to d7b6e8e Compare February 24, 2023 16:21
@rodiazet rodiazet requested a review from chfast February 24, 2023 16:21
rodiazet
rodiazet commented Feb 24, 2023
View reviewed changes
Comment thread test/state/state.cpp
});

return TransactionReceipt{gas_used, host.take_logs()};
auto receipt = TransactionReceipt{tx.kind, result.status_code, gas_used, host.take_logs(), {}};
Copy link
Copy Markdown
Member Author

@rodiazet rodiazet Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chfast Reviewing it for the last time I changed initialisation of receipt status filed to result.status_code from EVMC_SUCCESS. I think the prev version was wrong.

chfast
chfast approved these changes Feb 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@rodiazet rodiazet merged commit b13f3d3 into master Feb 24, 2023
@rodiazet rodiazet deleted the tx-to-rlp branch February 24, 2023 22:21
hanzo-dev pushed a commit to luxcpp/cevm that referenced this pull request Apr 26, 2026
@rodiazet
Merge pull request ipsilon#569 from ethereum/tx-to-rlp
d70a68f 
RLP encoding and MPT hash calculation for `Transaction` and `TransactionReceipt`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chfast chfast chfast approved these changes

@axic axic Awaiting requested review from axic

@gumb0 gumb0 Awaiting requested review from gumb0

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rodiazet @axic @chfast @gumb0