Add specs for proposer preferences #4777
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensi321
reviewed
Dec 5, 2025
| `is_builder_withdrawal_credential(state.validators[bid.builder_index].withdrawal_credentials)` | ||
| returns `True`. | ||
| - _[REJECT]_ `bid.execution_payment` is zero. | ||
| - _[REJECT]_ `bid.fee_recipient` matches the `fee_recipient` from the proposer's |
Contributor
There was a problem hiding this comment.
Just want to point out that these rules are not enforceable at all.
eg. Proposer can still accept bid that has different fee recipient from ProposerPreferences and there is no consequence to it because process_execution_payload_bid will not check if the bid matches the preference. Ultimately proposer can choose whatever bid he is happy with, whether his preference has been met or not
Member
There was a problem hiding this comment.
I think the purpose of this is just to protect the proposer itself so the beacon node doesn't select a bid that violates the preference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no in-protocol method for proposers to provide their preferences (fee recipient and gas limit) to builders. I would like to suggest a new
proposer_preferencesgossip topic for this.Proposers in the next epoch (as defined by
proposer_lookahead) will broadcast their preferences to everyone (including builders). This means that there will only beSLOTS_PER_EPOCH(32) valid messages on this topic each epoch which is very minimal. There's plenty of time (a whole epoch) for the network propagate these messages too.