Skip to content

Commit b3371b6

Browse files
@jtraglia's suggestions
Co-authored-by: Justin Traglia <[email protected]>
1 parent e678deb commit b3371b6

3 files changed

Lines changed: 10 additions & 10 deletions

File tree

specs/_features/eip7805/beacon-chain.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ This is the beacon chain specification to add EIP-7805 / fork-choice enforced, c
4343

4444
| Name | Value |
4545
| - | - |
46-
| `DOMAIN_IL_COMMITTEE` | `DomainType('0x0C000000')` # (New in EIP-7805)|
46+
| `DOMAIN_IL_COMMITTEE` | `DomainType('0x0C000000')` # (New in EIP7805) |
4747

4848
### Inclusion List Committee
4949

@@ -55,7 +55,7 @@ This is the beacon chain specification to add EIP-7805 / fork-choice enforced, c
5555

5656
| Name | Value |
5757
| - | - |
58-
| `MAX_TRANSACTIONS_PER_INCLUSION_LIST` | `uint64(1)` # (New in EIP-7805) TODO: Placeholder |
58+
| `MAX_TRANSACTIONS_PER_INCLUSION_LIST` | `uint64(1)` # (New in EIP-7805) TODO: Placeholder |
5959

6060
## Containers
6161

@@ -88,14 +88,14 @@ def is_valid_inclusion_list_signature(
8888
state: BeaconState,
8989
signed_inclusion_list: SignedInclusionList) -> bool:
9090
"""
91-
Check if ``signed_inclusion_list`` has a valid signature
91+
Check if ``signed_inclusion_list`` has a valid signature.
9292
"""
9393
message = signed_inclusion_list.message
9494
index = message.validator_index
9595
pubkey = state.validators[index].pubkey
9696
domain = get_domain(state, DOMAIN_IL_COMMITTEE, compute_epoch_at_slot(message.slot))
9797
signing_root = compute_signing_root(message, domain)
98-
return bls.FastAggregateVerify(pubkey, signing_root, signed_inclusion_list.signature)
98+
return bls.Verify(pubkey, signing_root, signed_inclusion_list.signature)
9999
```
100100

101101
### Beacon State accessors

specs/_features/eip7805/fork-choice.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ This is the modification of the fork choice accompanying the EIP-7805 upgrade.
2121

2222
| Name | Value | Unit | Duration |
2323
| - | - | :-: | :-: |
24-
| `VIEW_FREEZE_DEADLINE` | `uint64(9)` | seconds | 9 seconds | # [New in EIP-7805]
24+
| `VIEW_FREEZE_DEADLINE` | `uint64(9)` | seconds | 9 seconds # (New in EIP7805) |
2525

2626
## Helpers
2727

@@ -68,7 +68,7 @@ def on_inclusion_list(
6868
signed_inclusion_list: SignedInclusionList,
6969
inclusion_list_committee: Vector[ValidatorIndex, IL_COMMITTEE_SIZE]]) -> None:
7070
"""
71-
``on_inclusion_list`` verify the inclusion list before importing it to fork choice store.
71+
Verify the inclusion list and import it into the fork choice store.
7272
If there exists more than 1 inclusion list in store with the same slot and validator index, remove the original one.
7373
"""
7474
message = signed_inclusion_list.message
@@ -98,7 +98,7 @@ def on_inclusion_list(
9898
if validator_index not in inclusion_list_equivocators[(message.slot, root)]:
9999
if validator_index in [il.validator_index for il in inclusion_lists[(message.slot, root)]]:
100100
il = [il for il in inclusion_lists[(message.slot, root)] if il.validator_index == validator_index][0]
101-
if not il == message:
101+
if validator_il != message:
102102
# We have equivocation evidence for `validator_index`, record it as equivocator
103103
inclusion_list_equivocators[(message.slot, root)].add(validator_index)
104104
# This inclusion list is not an equivocation. Store it if prior to the view freeze deadline

specs/_features/eip7805/validator.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ The body of these function is implementation dependent. The Engine API may be us
5151

5252
## New inclusion list committee assignment
5353

54-
A validator may be a member of the new Inclusion List Committee (ILC) for a given slot. To check for ILC assignments the validator uses the helper `get_ilc_assignment(state, epoch, validator_index)` where `epoch <= next_epoch`.
54+
A validator may be a member of the new Inclusion List Committee (ILC) for a given slot. To check for ILC assignments the validator uses the helper `get_ilc_assignment(state, epoch, validator_index)` where `epoch <= next_epoch`.
5555

5656
ILC selection is only stable within the context of the current and next epoch.
5757

@@ -82,7 +82,7 @@ def get_ilc_assignment(
8282

8383
### Block proposal
8484

85-
Proposers are still expected to propose `SignedBeaconBlock` at the beginning of any slot during which `is_proposer(state, validator_index)` returns `true`. The mechanism to prepare this beacon block and related sidecars differs from previous forks as follows:
85+
Proposers are still expected to propose `SignedBeaconBlock` at the beginning of any slot during which `is_proposer(state, validator_index)` returns true. The mechanism to prepare this beacon block and related sidecars differs from previous forks as follows:
8686

8787
#### Update execution client with inclusion lists
8888

@@ -93,7 +93,7 @@ The proposer should call `engine_updateInclusionListV1` at `PROPOSER_INCLUSION_L
9393

9494
Some validators are selected to submit signed inclusion list. Validators should call `get_ilc_assignment` at the beginning of an epoch to be prepared to submit their inclusion list during the next epoch.
9595

96-
A validator should create and broadcast the `signed_inclusion_list` to the global `inclusion_list` subnet by the `inclusion_list_CUT_OFF` in the slot, unless a block for the current slot has been processed and is the head of the chain and broadcast to the network.
96+
A validator should create and broadcast the `signed_inclusion_list` to the global `inclusion_list` subnet by `PROPOSER_INCLUSION_LIST_CUT_OFF` seconds into the slot, unless a block for the current slot has been processed and is the head of the chain and broadcast to the network.
9797

9898
#### Constructing a signed inclusion list
9999

0 commit comments

Comments
 (0)