-
Notifications
You must be signed in to change notification settings - Fork 149
Force go bindings to use portable blst #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a241b02
Add hack to force portable go bindings
jtraglia 639004d
Test not defining types
jtraglia 8ef5811
Change type of limb_t
jtraglia f1d6b18
Remove unnecessary include
jtraglia 2241d5d
Reorganize header file a little bit
jtraglia c2838f9
Replace assembly.S with file that includes it
jtraglia faaa3d4
Run tests on all platforms
jtraglia 34e6899
Update minimum go version
jtraglia 8da4099
Test with Go 1.11 too
jtraglia c92b46e
Change minimum Go version to 1.13
jtraglia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| /* | ||
| * For CGO to assemble the blst assembly files, the file MUST exist in the same | ||
| * directory as the main.go file. Instead of copying the whole | ||
| * blst/build/assembly.S file here, it should have the same effect to include | ||
| * it. Keep in mind, this while not work on Windows systems compiling with | ||
| * MSVC, but it will work with mingw32. | ||
| */ | ||
| #include "assembly.S" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.