Skip to content

Commit c0c9eb3

Browse files
authored
Update ERC-7540: Fix event names (#670)
* Update ERC-7540: Fix event names * undo lint * fixes * fixes
1 parent f39d74a commit c0c9eb3

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

ERCS/erc-7540.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ All ERC-7540 asynchronous tokenized Vaults MUST implement ERC-4626 with override
5252

5353
Asynchronous deposit Vaults MUST override the ERC-4626 specification as follows:
5454

55-
1. The `deposit` and `mint` methods do not transfer `assets` to the Vault, because this already happened on `requestDeposit`.
55+
1. The `deposit` and `mint` methods do not transfer `assets` to the Vault, because this already happened on `requestDeposit`.
5656
2. `previewDeposit` and `previewMint` MUST revert for all callers and inputs.
5757

5858
Asynchronous redeem Vaults MUST override the ERC-4626 specification as follows:
@@ -69,11 +69,11 @@ After submission, Requests go through Pending, Claimable, and Claimed stages. An
6969
|-------------|---------------------------------|-----------|
7070
| Pending | `requestDeposit(assets, controller, owner)` | `asset.transferFrom(owner, vault, assets)`; `pendingDepositRequest[controller] += assets` |
7171
| Claimable | | *Internal Request fulfillment*: `pendingDepositRequest[controller] -= assets`; `claimableDepositRequest[controller] += assets` |
72-
| Claimed | `deposit(assets, receiver)` | `claimableDepositRequest[controller] -= assets`; `vault.balanceOf[receiver] += shares` |
72+
| Claimed | `deposit(assets, receiver, controller)` | `claimableDepositRequest[controller] -= assets`; `vault.balanceOf[receiver] += shares` |
7373

7474
Note that `maxDeposit` increases and decreases in sync with `claimableDepositRequest`.
7575

76-
Requests MUST NOT skip or otherwise short-circuit the Claim state. In other words, to initiate and claim a Request, a user MUST call both request* and the corresponding claim* function separately, even in the same block. Vaults MUST NOT "push" tokens onto the user after a Request, users MUST "pull" the tokens via the Claim function.
76+
Requests MUST NOT skip or otherwise short-circuit the Claim state. In other words, to initiate and claim a Request, a user MUST call both request* and the corresponding Claim function separately, even in the same block. Vaults MUST NOT "push" tokens onto the user after a Request, users MUST "pull" the tokens via the Claim function.
7777

7878
For asynchronous Vaults, the exchange rate between `shares` and `assets` including fees and yield is up to the Vault implementation. In other words, pending redemption Requests MAY NOT be yield-bearing and MAY NOT have a fixed exchange rate.
7979

@@ -108,7 +108,7 @@ MUST revert if all of `assets` cannot be requested for `deposit`/`mint` (due to
108108

109109
Note that most implementations will require pre-approval of the Vault with the Vault's underlying `asset` token.
110110

111-
MUST emit the `RequestDeposit` event.
111+
MUST emit the `DepositRequest` event.
112112

113113
```yaml
114114
- name: requestDeposit
@@ -197,7 +197,7 @@ The `assets` that will be received on `redeem` or `withdraw` MAY NOT be equivale
197197

198198
MUST revert if all of `shares` cannot be requested for `redeem` / `withdraw` (due to withdrawal limit being reached, slippage, the owner not having enough shares, etc).
199199

200-
MUST emit the `RequestRedeem` event.
200+
MUST emit the `RedeemRequest` event.
201201

202202
```yaml
203203
- name: requestRedeem
@@ -562,4 +562,4 @@ Any user approving an operator must trust that operator with both the `asset` an
562562

563563
## Copyright
564564

565-
Copyright and related rights waived via [CC0](../LICENSE.md).
565+
Copyright and related rights waived via [CC0](../LICENSE.md).

0 commit comments

Comments
 (0)