feat(op-acceptance-tests): add more sysgo tests.

Author: scharissis

.circleci/config.yml

@@ -1185,6 +1185,7 @@ jobs:
         description: The gate to run the acceptance tests against. This gate should be defined in op-acceptance-tests/acceptance-tests.yaml.
         type: string
         default: ""
+
       no_output_timeout:
         description: Timeout for when CircleCI kills the job if there's no output
         type: string
@@ -1256,15 +1257,19 @@ jobs:
           command: go test -v -c -o /dev/null $(go list -f '{{if .TestGoFiles}}{{.ImportPath}}{{end}}' ./tests/...)
       # Run the acceptance tests (if the devnet is running)
       - run:
-          name: Run acceptance tests (gate=<<parameters.gate>>)
+          name: Run acceptance tests
           working_directory: op-acceptance-tests
           no_output_timeout: 1h
           environment:
             GOFLAGS: "-mod=mod"
             GO111MODULE: "on"
             GOGC: "0"
           command: |
-            # Run the tests
+            if [[ "<<parameters.gate>>" == "" ]]; then
+              echo "Running in gateless mode - auto-discovering all tests in ./op-acceptance-tests/..."
+            else
+              echo "Running in gate mode (gate=<<parameters.gate>>)"
+            fi
             LOG_LEVEL=debug just acceptance-test "<<parameters.devnet>>" "<<parameters.gate>>"
       - run:
           name: Print results (summary)
@@ -2349,7 +2354,7 @@ workflows:
       - cannon-prestate-quick:  # needed for sysgo tests
           context:
             - circleci-repo-readonly-authenticated-github-token
-      # IN-PROCESS (base)
+      # IN-MEMORY (base)
       - op-acceptance-tests:
           # Acceptance Testing params
           name: memory-base
@@ -2362,6 +2367,17 @@ workflows:
           requires:
             - contracts-bedrock-build
             - cannon-prestate-quick
+      # IN-MEMORY (all)
+      - op-acceptance-tests:
+          name: memory-all
+          gate: ""  # Empty gate = gateless mode
+          no_output_timeout: 60m
+          context:
+            - circleci-repo-readonly-authenticated-github-token
+            - discord
+          requires:
+            - contracts-bedrock-build
+            - cannon-prestate-quick
       # KURTOSIS (Simple)
       - op-acceptance-tests:
           # Acceptance Testing params
@@ -2414,7 +2430,7 @@ workflows:
       - cannon-prestate-quick:  # needed for sysgo tests
           context:
             - circleci-repo-readonly-authenticated-github-token
-      # IN-PROCESS (base)
+      # IN-MEMORY (base)
       - op-acceptance-tests:
           # Acceptance Testing params
           name: memory-base
@@ -2427,6 +2443,17 @@ workflows:
           requires:
             - contracts-bedrock-build
             - cannon-prestate-quick
+      # IN-MEMORY (all)
+      - op-acceptance-tests:
+          name: memory-all
+          gate: ""  # Empty gate = gateless mode
+          no_output_timeout: 60m
+          context:
+            - circleci-repo-readonly-authenticated-github-token
+            - discord
+          requires:
+            - contracts-bedrock-build
+            - cannon-prestate-quick
       # KURTOSIS (Simple)
       - op-acceptance-tests:
           # Acceptance Testing params

mise.toml

@@ -38,7 +38,7 @@ anvil = "1.1.0"
 codecov-uploader = "0.8.0"
 goreleaser-pro = "2.3.2-pro"
 kurtosis = "1.8.1"
-op-acceptor = "op-acceptor/v1.1.1"
+op-acceptor = "op-acceptor/v2.0.0"
 
 # Fake dependencies
 # Put things here if you need to track versions of tools or projects that can't

op-acceptance-tests/README.md

@@ -96,7 +96,8 @@ For rapid test development, use in-process testing:
 
 ```bash
 cd op-acceptance-tests
-just acceptance-test "" base  # Uses sysgo orchestrator - faster!
+# Not providing a network uses the sysgo orchestrator (in-memory network) which is faster and easier to iterate with.
+just acceptance-test "" base
 ```
 
 ### Testing Against External Devnets
@@ -163,8 +164,25 @@ To add new acceptance tests:
      package: github.com/ethereum-optimism/optimism/your/package/path
    ```
 
+### Quick Development
+
+For rapid development and testing:
+
+```bash
+cd op-acceptance-tests
+
+# Run all tests (sysgo gateless mode) - most comprehensive coverage
+just acceptance-test "" ""
+
+# Run specific gate-based tests (traditional mode)
+just acceptance-test "" base        # In-process (sysgo) with gate
+just acceptance-test simple base    # External devnet (sysext) with gate
+```
+
+Using an empty gate (`""`) triggers gateless mode with the sysgo orchestrator, auto-discovering all tests.
+
 ## Further Information
 
 For more details about `op-acceptor` and the acceptance testing process, refer to the main documentation or ask the team for guidance.
 
-The source code for `op-acceptor` is available at [github.com/ethereum-optimism/infra/op-acceptor](https://github.com/ethereum-optimism/infra/tree/main/op-acceptor). If you discover any bugs or have feature requests, please open an issue in that repository.
+The source code for `op-acceptor` is available at [github.com/ethereum-optimism/infra/op-acceptor](https://github.com/ethereum-optimism/infra/tree/main/op-acceptor). If you discover any bugs or have feature requests, please open an issue in that repository.

op-acceptance-tests/justfile

@@ -8,6 +8,8 @@ ACCEPTOR_IMAGE := env_var_or_default("ACCEPTOR_IMAGE", DOCKER_REGISTRY + "/op-ac
 default:
     @just acceptance-test simple base
 
+
+
 holocene:
     @just acceptance-test simple holocene
 
@@ -19,27 +21,27 @@ interop:
 
 
 # Run acceptance tests with mise-managed binary
+# Usage: just acceptance-test [devnet] [gate]
+# Examples:
+#   just acceptance-test simple base     # External devnet with specific gate
+#   just acceptance-test "" base         # In-process (sysgo) with specific gate
+#   just acceptance-test "" ""           # In-process gateless mode (all tests)
 acceptance-test devnet="" gate="holocene":
     #!/usr/bin/env bash
     set -euo pipefail
 
-     # Check if mise is installed
-    if command -v mise >/dev/null; then
-        echo "mise is installed"
-    else
-        echo "Mise not installed, falling back to Docker..."
-        just acceptance-test-docker {{devnet}} {{gate}}
-    fi
-
-    if [[ "{{devnet}}" == "" ]]; then
-        echo -e "DEVNET: in-memory, GATE: {{gate}}\n"
+    # Determine if we're running in gateless mode (empty gate = gateless)
+    GATELESS_MODE=false
+    if [[ "{{gate}}" == "" ]]; then
+        GATELESS_MODE=true
+        echo -e "DEVNET: in-memory (sysgo), MODE: gateless (all tests)\n"
+    elif [[ "{{devnet}}" == "" ]]; then
+        echo -e "DEVNET: in-memory (sysgo), GATE: {{gate}}\n"
     else
-        echo -e "DEVNET: {{devnet}}, GATE: {{gate}}\n"
+        echo -e "DEVNET: {{devnet}} (sysext), GATE: {{gate}}\n"
     fi
 
-    # For sysgo orchestrator (in-process testing) ensure:
-    # - contracts are built
-    # - cannon dependencies are built
+    # For sysgo orchestrator (in-process testing) ensure dependencies are built
     # Note: build contracts only if not in CI (CI jobs already take care of this)
     if [[ "{{devnet}}" == "" && -z "${CIRCLECI:-}" ]]; then
         echo "Building contracts (local build)..."
@@ -63,6 +65,19 @@ acceptance-test devnet="" gate="holocene":
         fi
     fi
 
+    cd {{REPO_ROOT}}/op-acceptance-tests
+
+
+    # Gate mode: use existing gate-based approach
+    # Check if mise is installed
+    if command -v mise >/dev/null; then
+        echo "mise is installed"
+    else
+        echo "Mise not installed, falling back to Docker..."
+        just acceptance-test-docker {{devnet}} {{gate}}
+        exit 0
+    fi
+
     # Try to install op-acceptor using mise
     if ! mise install op-acceptor; then
         echo "WARNING: Failed to install op-acceptor with mise, falling back to Docker..."
@@ -74,31 +89,45 @@ acceptance-test devnet="" gate="holocene":
     BINARY_PATH=$(mise which op-acceptor)
     echo "Using mise-managed binary: $BINARY_PATH"
 
-    # Build the command with conditional parameters
-    CMD_ARGS=(
-        "go" "run" "cmd/main.go"
-        "--gate" "{{gate}}"
-        "--testdir" "{{REPO_ROOT}}"
-        "--validators" "./acceptance-tests.yaml"
-        "--log.level" "${LOG_LEVEL:-info}"
-        "--acceptor" "$BINARY_PATH"
-    )
-
-    # Set orchestrator and devnet based on input
-    if [[ "{{devnet}}" == "" ]]; then
-        # In-process testing
-        CMD_ARGS+=("--orchestrator" "sysgo")
+    if [[ "$GATELESS_MODE" == "true" ]]; then
+        # Gateless mode: auto-discover all tests within a directory
+        echo "Running gateless mode - auto-discovering all tests in ./op-acceptance-tests/..."
+
+        # (Temporarily) allow skips
+        op-acceptor \
+            --testdir {{REPO_ROOT}}/op-acceptance-tests/... \
+            --orchestrator sysgo \
+            --allow-skips \
+            --timeout 90m \
+            --log.level "${LOG_LEVEL:-info}"
     else
-        # External devnet testing
-        CMD_ARGS+=("--orchestrator" "sysext")
-        CMD_ARGS+=("--devnet" "{{devnet}}")
-        # Include kurtosis-dir for devnet deployment
-        CMD_ARGS+=("--kurtosis-dir" "{{KURTOSIS_DIR}}")
-    fi
+        # Gate mode: use a gate-based testing approach
+
+        # Build the command with conditional parameters
+        CMD_ARGS=(
+            "go" "run" "cmd/main.go"
+            "--gate" "{{gate}}"
+            "--testdir" "{{REPO_ROOT}}"
+            "--validators" "./acceptance-tests.yaml"
+            "--log.level" "${LOG_LEVEL:-info}"
+            "--acceptor" "$BINARY_PATH"
+        )
+
+        # Set orchestrator and devnet based on input
+        if [[ "{{devnet}}" == "" ]]; then
+            # In-process testing
+            CMD_ARGS+=("--orchestrator" "sysgo")
+        else
+            # External devnet testing
+            CMD_ARGS+=("--orchestrator" "sysext")
+            CMD_ARGS+=("--devnet" "{{devnet}}")
+            # Include kurtosis-dir for devnet deployment
+            CMD_ARGS+=("--kurtosis-dir" "{{KURTOSIS_DIR}}")
+        fi
 
-    # Execute the command
-    cd {{REPO_ROOT}}/op-acceptance-tests
-    "${CMD_ARGS[@]}"
+        # Execute the command
+        "${CMD_ARGS[@]}"
+    fi
 
 
 # Run acceptance tests against a devnet using Docker (fallback if needed)