Commit e437823
authored
fix: correct samoid-hook argument usage in performance benchmarks (#32)
The performance benchmarks were incorrectly calling samoid-hook with --help,
but samoid-hook expects a hook name as the first argument and doesn't support
--help. This was causing the performance pipeline to fail.
Changes:
- Fixed benchmark_startup_time_samoid_hook_cli to use 'non-existent-hook'
argument instead of --help, which measures startup overhead correctly
- Updated perf.yml workflow memory test to use 'non-existent-hook' argument
instead of --help for consistent behavior
- Added proper environment variable SAMOID=1 to ensure hook runner attempts
execution for accurate performance measurement
These changes ensure the performance benchmarks measure the actual startup
time and memory usage of samoid-hook without trying to execute non-existent
hooks, which is the intended behavior for performance testing.1 parent 5a5b534 commit e437823
2 files changed
Lines changed: 10 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
160 | 160 | | |
161 | 161 | | |
162 | 162 | | |
163 | | - | |
| 163 | + | |
164 | 164 | | |
165 | 165 | | |
166 | | - | |
| 166 | + | |
167 | 167 | | |
168 | | - | |
| 168 | + | |
169 | 169 | | |
170 | 170 | | |
171 | 171 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
318 | 318 | | |
319 | 319 | | |
320 | 320 | | |
| 321 | + | |
| 322 | + | |
321 | 323 | | |
322 | | - | |
| 324 | + | |
| 325 | + | |
323 | 326 | | |
324 | 327 | | |
325 | 328 | | |
326 | 329 | | |
327 | 330 | | |
328 | | - | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
329 | 334 | | |
330 | 335 | | |
331 | 336 | | |
| |||
0 commit comments