make ignoreAssignmentVariable recursive

Author: gurgunday

__tests__/always-return.js

@@ -106,8 +106,11 @@ ruleTester.run('always-return', rule, {
       options: [{ ignoreLastCallback: true }],
     },
     `hey.then(x => { window.a = x })`,
+    `hey.then(x => { window.a.n = x })`,
+    `hey.then(x => { window[12] = x })`,
+    `hey.then(x => { window[12]["test"] = x })`,
     {
-      code: `hey.then(x => { window.a.x = x })`,
+      code: `hey.then(x => { window.a.x.y = x })`,
       options: [{ ignoreAssignmentVariable: ['window.a'] }],
     },
     {
@@ -255,17 +258,12 @@ ruleTester.run('always-return', rule, {
     },
     {
       code: `hey.then(x => { ++window.a })`,
-      options: [{ ignoreAssignmentVariable: ['window.a'] }],
-      errors: [{ message }],
-    },
-    {
-      code: `hey.then(x => { window.a.b.c = x })`,
-      options: [{ ignoreAssignmentVariable: ['window.a'] }],
+      options: [{ ignoreAssignmentVariable: ['window', 'window.a'] }],
       errors: [{ message }],
     },
     {
       code: `hey.then(x => { let a = x })`,
-      options: [{ ignoreAssignmentVariable: ['window.a'] }],
+      options: [{ ignoreAssignmentVariable: ['window'] }],
       errors: [{ message }],
     },
   ],

rules/always-return.js

@@ -124,6 +124,36 @@ function peek(arr) {
   return arr[arr.length - 1]
 }
 
+/**
+ * Gets the full object name for a MemberExpression or Identifier
+ * @param {import('estree').MemberExpression | import('estree').Identifier} node
+ * @returns {string}
+ */
+function getFullObjectName(node) {
+  if (node.type === 'Identifier') {
+    return node.name
+  }
+  const objectName = getFullObjectName(node.object)
+  const propertyName = node.property.name
+  return `${objectName}${node.computed ? '[' : '.'}${propertyName}${node.computed ? ']' : ''}`
+}
+
+/**
+ * Checks if the given name starts with an ignored variable
+ * @param {string} name
+ * @param {string[]} ignoredVars
+ * @returns {boolean}
+ */
+function startsWithIgnoredVar(name, ignoredVars) {
+  return ignoredVars.some(
+    (ignoredVar) =>
+      name === ignoredVar ||
+      (name.startsWith(ignoredVar) &&
+        (name.charAt(ignoredVar.length) === '.' ||
+          name.charAt(ignoredVar.length) === '[')),
+  )
+}
+
 /**
  * Checks if the node is an assignment to an ignored variable
  * @param {Node} node
@@ -137,17 +167,10 @@ function isIgnoredAssignment(node, ignoredVars) {
   const left = expr.left
   // istanbul ignore else
   if (left.type === 'MemberExpression') {
-    if (left.object.type === 'Identifier') {
-      return ignoredVars.includes(left.object.name)
-    }
-    if (
-      left.object.type === 'MemberExpression' &&
-      left.object.object.type === 'Identifier'
-    ) {
-      const fullName = `${left.object.object.name}.${left.object.property.name}`
-      return ignoredVars.includes(fullName)
-    }
+    const fullName = getFullObjectName(left.object)
+    return startsWithIgnoredVar(fullName, ignoredVars)
   }
+  // istanbul ignore next
   // fallback
   return false
 }