fix(ci): Ignore type test failures for types present in ESLint 8 that we removed in ESLint 9.31.0 #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2025
[email protected] removed some of the RuleContext types (see eslint/eslint#19910), causing the `test:types` CI script to fail. Since eslint-plugin-n still needs to support 8.x versions of eslint, the implementation that relies on RuleContexts can't be removed. A simple solution to unblock the CI is to annotate the few places that rely on them with @ts-ignore. When eslint 8.x support is dropped, these annotations should be removed. That, in turn, will expose the code that relies on eslint 8.x APIs, which should then also be removed. As part of this PR, the eslint dependency was bumped to ^9.31.0. This was done in order to prevent developers from developing locally with older 9.x versions of eslint and accidentally introducing new code that relies of these types with properly handling the type annotations and having it fail in the CI. Fixes eslint-community#459
mureinik
changed the title
This was referenced Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[email protected] removed some of the RuleContext types (see eslint/eslint#19910), causing the
test:typesCI script to fail.Since
eslint-plugin-nstill needs to support 8.x versions ofeslint, the implementation that relies onRuleContexts can't be removed.A simple solution to unblock the CI is to annotate the few places that rely on them with
@ts-ignore.When
eslint8.x support is dropped, these annotations should be removed. That, in turn, will expose the code that relies oneslint8.x APIs, which should then also be removed.As part of this PR, the
eslintdependency was bumped to^9.31.0.This was done in order to prevent developers from developing locally with older 9.x versions of
eslintand accidentally introducing new code that relies on these types without properly handling the type annotations and having it fail in the CI.Fixes #459