Caplin: Remove TmpDB from BlockCollector (#11215)

Co-authored-by: Alex Sharov <[email protected]>

Author: Giulio2002

cl/phase1/execution_client/block_collector/block_collector.go

@@ -23,9 +23,7 @@ import (
 
 	"github.com/ledgerwatch/erigon-lib/common"
 	"github.com/ledgerwatch/erigon-lib/etl"
-	"github.com/ledgerwatch/erigon-lib/kv"
 	"github.com/ledgerwatch/erigon-lib/kv/dbutils"
-	"github.com/ledgerwatch/erigon-lib/kv/memdb"
 	"github.com/ledgerwatch/erigon-lib/log/v3"
 	"github.com/ledgerwatch/erigon/cl/clparams"
 	"github.com/ledgerwatch/erigon/cl/cltypes"
@@ -91,19 +89,11 @@ func (b *blockCollector) Flush(ctx context.Context) error {
 	if b.size == 0 {
 		return nil
 	}
-	tmpDB := memdb.New(b.tmpdir)
-	defer tmpDB.Close()
-	defer b.collector.Close()
-	tmpTx, err := tmpDB.BeginRw(ctx)
-	if err != nil {
-		return err
-	}
-	defer tmpTx.Rollback()
 	blocksBatch := []*types.Block{}
-
+	var err error
 	inserted := uint64(0)
 
-	if err := b.collector.Load(tmpTx, kv.Headers, func(k, v []byte, table etl.CurrentTableReader, next etl.LoadNextFunc) error {
+	if err := b.collector.Load(nil, "", func(k, v []byte, table etl.CurrentTableReader, next etl.LoadNextFunc) error {
 		if len(v) == 0 {
 			return nil
 		}

erigon-lib/etl/collector.go

@@ -257,6 +257,10 @@ func (c *Collector) Load(db kv.RwTx, toBucket string, loadFunc LoadFunc, args Tr
 		return nil
 	}
 
+	if bucket == "" {
+		loadNextFunc = func(_, k, v []byte) error { return nil }
+	}
+
 	currentTable := &currentTableReader{db, bucket}
 	simpleLoad := func(k, v []byte) error {
 		return loadFunc(k, v, currentTable, loadNextFunc)