Skip to content

Conversation

@greenhat
Copy link
Member

@greenhat greenhat commented Feb 14, 2023

Close #173
Close #219
Close #226
Close #159

Todo:

use SpecToken for reward tokens in vote-update and update-pool commands;
@greenhat greenhat force-pushed the i173-reward-tokens-update branch from 38e9c79 to ae30e7c Compare February 15, 2023 12:29
@coveralls
Copy link

coveralls commented Feb 15, 2023

Pull Request Test Coverage Report for Build 4184184037

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 49 of 101 (48.51%) changed or added relevant lines in 14 files are covered.
  • 201 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.2%) to 61.227%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/contracts/update.rs 2 3 66.67%
core/src/cli_commands/prepare_update.rs 0 2 0.0%
core/src/box_kind/ballot_box.rs 15 18 83.33%
core/src/cli_commands/vote_update_pool.rs 2 9 22.22%
core/src/explorer_api.rs 0 12 0.0%
core/src/main.rs 0 12 0.0%
core/src/cli_commands/update_pool.rs 5 20 25.0%
Files with Coverage Reduction New Missed Lines %
core/src/cli_commands/vote_update_pool.rs 1 60.71%
core/src/contracts/oracle.rs 1 87.1%
core/src/pool_commands/test_utils.rs 2 93.94%
core/src/cli_commands.rs 6 0.0%
core/src/contracts/update.rs 6 81.82%
core/src/contracts/pool.rs 8 84.93%
core/src/cli_commands/prepare_update.rs 9 67.05%
core/src/contracts/ballot.rs 12 80.61%
core/src/explorer_api.rs 17 0.0%
core/src/contracts/refresh.rs 18 75.38%
Totals Coverage Status
Change from base Build 4144149595: -0.2%
Covered Lines: 2026
Relevant Lines: 3309

💛 - Coveralls

@greenhat greenhat marked this pull request as ready for review March 2, 2023 09:12
add `import-pool-update` command description in the readme;
@greenhat greenhat merged commit 32a41ed into develop Mar 2, 2023
@greenhat greenhat deleted the i173-reward-tokens-update branch March 2, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants