Ignore infinite timers in tests

Author: eps1lon

packages/react-devtools-shared/src/__tests__/bridge-test.js

@@ -26,15 +26,15 @@ describe('Bridge', () => {
 
     // Check that we're wired up correctly.
     bridge.send('reloadAppForProfiling');
-    jest.runAllTimers();
+    jest.runOnlyPendingTimers();
     expect(wall.send).toHaveBeenCalledWith('reloadAppForProfiling');
 
     // Should flush pending messages and then shut down.
     wall.send.mockClear();
     bridge.send('update', '1');
     bridge.send('update', '2');
     bridge.shutdown();
-    jest.runAllTimers();
+    jest.runOnlyPendingTimers();
     expect(wall.send).toHaveBeenCalledWith('update', '1');
     expect(wall.send).toHaveBeenCalledWith('update', '2');
     expect(wall.send).toHaveBeenCalledWith('shutdown');
@@ -44,7 +44,7 @@ describe('Bridge', () => {
     jest.spyOn(console, 'warn').mockImplementation(() => {});
     wall.send.mockClear();
     bridge.send('should not send');
-    jest.runAllTimers();
+    jest.runOnlyPendingTimers();
     expect(wall.send).not.toHaveBeenCalled();
     expect(console.warn).toHaveBeenCalledWith(
       'Cannot send message "should not send" through a Bridge that has been shutdown.',

packages/react-devtools-shared/src/__tests__/legacy/editing-test.js

@@ -20,7 +20,7 @@ describe('editing interface', () => {
   const act = (callback: Function) => {
     callback();
 
-    jest.runAllTimers(); // Flush Bridge operations
+    jest.runOnlyPendingTimers(); // Flush Bridge operations
   };
 
   const flushPendingUpdates = () => {

packages/react-devtools-shared/src/__tests__/legacy/inspectElement-test.js

@@ -21,7 +21,7 @@ describe('InspectedElementContext', () => {
   const act = (callback: Function) => {
     callback();
 
-    jest.runAllTimers(); // Flush Bridge operations
+    jest.runOnlyPendingTimers(); // Flush Bridge operations
   };
 
   async function read(

packages/react-devtools-shared/src/__tests__/legacy/storeLegacy-v15-test.js

@@ -13,7 +13,7 @@ describe('Store (legacy)', () => {
   let store;
   const act = (callback: Function) => {
     callback();
-    jest.runAllTimers(); // Flush Bridge operations
+    jest.runOnlyPendingTimers(); // Flush Bridge operations
   };
   beforeEach(() => {
     store = global.store;

packages/react-devtools-shared/src/__tests__/store-test.js

@@ -1978,7 +1978,7 @@ describe('Store', () => {
       clearErrorsAndWarnings({bridge, store});
 
       // flush events to the renderer
-      jest.runAllTimers();
+      jest.runOnlyPendingTimers();
 
       expect(store).toMatchInlineSnapshot(`
         [root]
@@ -2022,7 +2022,7 @@ describe('Store', () => {
       clearWarningsForElement({bridge, id, rendererID});
 
       // Flush events to the renderer.
-      jest.runAllTimers();
+      jest.runOnlyPendingTimers();
 
       expect(store).toMatchInlineSnapshot(`
         ✕ 2, ⚠ 1
@@ -2067,7 +2067,7 @@ describe('Store', () => {
       clearErrorsForElement({bridge, id, rendererID});
 
       // Flush events to the renderer.
-      jest.runAllTimers();
+      jest.runOnlyPendingTimers();
 
       expect(store).toMatchInlineSnapshot(`
         ✕ 1, ⚠ 2

packages/react-devtools-shared/src/__tests__/treeContext-test.js

@@ -1421,21 +1421,21 @@ describe('TreeListContext', () => {
     function clearAllErrors() {
       utils.act(() => clearErrorsAndWarningsAPI({bridge, store}));
       // flush events to the renderer
-      jest.runAllTimers();
+      jest.runOnlyPendingTimers();
     }
 
     function clearErrorsForElement(id) {
       const rendererID = store.getRendererIDForElement(id);
       utils.act(() => clearErrorsForElementAPI({bridge, id, rendererID}));
       // flush events to the renderer
-      jest.runAllTimers();
+      jest.runOnlyPendingTimers();
     }
 
     function clearWarningsForElement(id) {
       const rendererID = store.getRendererIDForElement(id);
       utils.act(() => clearWarningsForElementAPI({bridge, id, rendererID}));
       // flush events to the renderer
-      jest.runAllTimers();
+      jest.runOnlyPendingTimers();
     }
 
     function selectNextErrorOrWarning() {
@@ -2358,7 +2358,7 @@ describe('TreeListContext', () => {
         );
         utils.act(() => TestRenderer.create(<Contexts />));
 
-        jest.runAllTimers();
+        jest.runOnlyPendingTimers();
 
         expect(state).toMatchInlineSnapshot(`
                   [root]

packages/react-devtools-shared/src/__tests__/utils.js

@@ -81,10 +81,11 @@ export function act(
 
   if (recursivelyFlush) {
     // Flush Bridge operations
-    while (jest.getTimerCount() > 0) {
+    // We have always one pending timer running that resets the Owner Stack limit.
+    while (jest.getTimerCount() > 1) {
       actDOM(() => {
         actTestRenderer(() => {
-          jest.runAllTimers();
+          jest.runOnlyPendingTimers();
         });
       });
     }
@@ -107,10 +108,11 @@ export async function actAsync(
   });
 
   if (recursivelyFlush) {
-    while (jest.getTimerCount() > 0) {
+    // We have always one pending timer running that resets the Owner Stack limit.
+    while (jest.getTimerCount() > 1) {
       await actDOM(async () => {
         await actTestRenderer(async () => {
-          jest.runAllTimers();
+          jest.runOnlyPendingTimers();
         });
       });
     }

packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js

@@ -2881,7 +2881,7 @@ describe('ReactDOMFizzServer', () => {
         root.render(<App color="blue" />);
       });
       await waitForAll([]);
-      jest.runAllTimers();
+      jest.runOnlyPendingTimers();
       const clientFallback2 = container.getElementsByTagName('p')[0];
       expect(clientFallback2).toBe(serverFallback);
 
@@ -2987,7 +2987,7 @@ describe('ReactDOMFizzServer', () => {
       // actually force it to re-render on the client and throw away the server one.
       root.render(<App fallbackText="More loading..." />);
       await waitForAll([]);
-      jest.runAllTimers();
+      jest.runOnlyPendingTimers();
       assertLog([
         'onRecoverableError: The server could not finish this Suspense boundary, ' +
           'likely due to an error during server rendering. ' +
@@ -6414,7 +6414,7 @@ describe('ReactDOMFizzServer', () => {
       ref.current.dispatchEvent(
         new window.MouseEvent('click', {bubbles: true}),
       );
-      await jest.runAllTimers();
+      await jest.runOnlyPendingTimers();
       expect(getVisibleChildren(container)).toEqual(<button>1</button>);
     });
 

packages/react-dom/src/__tests__/ReactDOMFizzServerNode-test.js

@@ -144,14 +144,14 @@ describe('ReactDOMFizzServerNode', () => {
         },
       },
     );
-    await jest.runAllTimers();
+    await jest.runOnlyPendingTimers();
     expect(output.result).toBe('');
     expect(isCompleteCalls).toBe(0);
     // Resolve the loading.
     hasLoaded = true;
     await resolve();
 
-    await jest.runAllTimers();
+    await jest.runOnlyPendingTimers();
 
     expect(output.result).toBe('');
     expect(isCompleteCalls).toBe(1);
@@ -354,7 +354,7 @@ describe('ReactDOMFizzServerNode', () => {
     const theReason = new Error('uh oh');
     abort(theReason);
 
-    jest.runAllTimers();
+    jest.runOnlyPendingTimers();
 
     await completed;
 
@@ -632,7 +632,7 @@ describe('ReactDOMFizzServerNode', () => {
 
     writable.end();
 
-    await jest.runAllTimers();
+    await jest.runOnlyPendingTimers();
 
     hasLoaded = true;
     resolve();

packages/react-dom/src/__tests__/ReactDOMFizzStaticBrowser-test.js

@@ -225,7 +225,7 @@ describe('ReactDOMFizzStaticBrowser', () => {
       ),
     );
 
-    await jest.runAllTimers();
+    await jest.runOnlyPendingTimers();
 
     // Resolve the loading.
     hasLoaded = true;
@@ -354,7 +354,7 @@ describe('ReactDOMFizzStaticBrowser', () => {
       ),
     );
 
-    await jest.runAllTimers();
+    await jest.runOnlyPendingTimers();
 
     const theReason = new Error('aborted for reasons');
     controller.abort(theReason);
@@ -387,7 +387,7 @@ describe('ReactDOMFizzStaticBrowser', () => {
       ),
     );
 
-    await jest.runAllTimers();
+    await jest.runOnlyPendingTimers();
 
     const theReason = new Error('aborted for reasons');
     controller.abort(theReason);
@@ -1377,7 +1377,7 @@ describe('ReactDOMFizzStaticBrowser', () => {
       ),
     );
 
-    await jest.runAllTimers();
+    await jest.runOnlyPendingTimers();
 
     expect(getVisibleChildren(container)).toEqual(<div>Loading...</div>);