paien: added tophat to Core (package does not compile with newer GCC) #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@rmsds The x86_E5v2_Mellanox_GPU worker is down, should we remove it from config? |
gio31415
reviewed
May 6, 2019
Collaborator
gio31415
left a comment
gio31415
left a comment
There was a problem hiding this comment.
Even though the package doesn't compile with newer GCC, it is worth while adding it to the official Core. I don't think that the performance of the program is dramatically affected by that.
Contributor
|
I know this builds fine and I would be ok with it as is, but I found a solution for building tophat with Please see epfl-scitas/spack#234 If you think it's not worth the effort I'm OK with the PR as is. |
rmsds
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.